Re: [cdi-dev] TCK: Why are there two different ways to exclude tests?

[Matej Novotny <manovotn@xxxxxxxxxx>]

IIRC, according to the TCK documentation[1], only the tck-tests.xml file is taken into consideration as that it is considered a canonical configuration file for test runs.

If we have test exclusions directly in the code, then those should be inspected and either remove the disablement if it was resolved or moved into this xml file.

I've created an issue[2] to track this.

Regards

Matej

_______________________________________________________

[1 ]https://github.com/jakartaee/cdi-tck/tree/master/doc/reference

[2] https://github.com/jakartaee/cdi-tck/issues/446

On Wed, Mar 22, 2023 at 12:46 AM Brian M Decker <bmdecker@xxxxxxxxxx> wrote:

Hello,

 

I was looking through TCK results in closer detail and noticed that there seem to be two different ways that tests are excluded in this TCK. Is that intentional for some reason, or should one mechanism be chosen for consistency?

3 tests are excluded in the tck-tests.xml files packaged in the TCK -- https://github.com/jakartaee/cdi-tck/blob/master/web/src/main/resources/tck-tests.xml & https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/resources/tck-tests.xml

 

2 more tests are excluded directly in the test code -- https://github.com/jakartaee/cdi-tck/blob/master/web/src/main/java/org/jboss/cdi/tck/tests/definition/bean/types/enterprise/illegal/BeanTypesWithIllegalTypeTest.java#L62 & https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/java/org/jboss/cdi/tck/tests/full/definition/bean/custom/CustomBeanImplementationTest.java#L143

 

Even though I recently updated one of the tck-tests.xml files, I actually prefer disabling them in the code and would probably have done so if I’d realized it was an acceptable option for this TCK.

 

-Brian

_______________________________________________
cdi-dev mailing list
cdi-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdi-dev