Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdi-dev] TCK: Why are there two different ways to exclude tests?
  • From: Brian M Decker <bmdecker@xxxxxxxxxx>
  • Date: Tue, 21 Mar 2023 23:46:22 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=us.ibm.com; dmarc=pass action=none header.from=us.ibm.com; dkim=pass header.d=us.ibm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=edMzlWpoV+ogO1v2CZCbTAi/xfQQTv5YGiFRzIeF1Ok=; b=W0QQUWlSJrKFaA7GCoMVkA1KJdiqmXKF6040LylM6b+U4xTl0OHeLHkH4JufBYBmpoGoB+LAK53l1zmg+Qypt+/OlkB9TgOblDvZao5/FocHBWdEc4tKLO6UMINKdoJgmOfHWd0sTuNU44KWKSPzGLVtNEFjrH1smEcX9KNWQcQ6xU0WsU8G443KJEB/9f6JIQi/mUX7W/NCr35SBYd8IcHMWIfu/Gsd7BSa8rqblo9SJaJhatyg6NOvM2YmgCtAEiwG6lB7ujCSSpRQ2XnLNqp6BwIyfA7y9IbaJLumnmzNxhKLHqvxW9gBvp6xaGwUQBGwHYFxnpmjVgkWXl1++A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUs0WWJA7Y/ssSijUn4fpghjoVMDOrKHFwBOj7MvJe80oHPjghxZ3A3PBrpWoMXheSwbl7xIxp34Uf5orDkEnBaqqc4id/GPkBi1DmkmmPuF/0ijzll4uvuXfsXOkCw7/H6J2I4CKOdcbkD1XwfYzFQX8GgtNqA/o5v260oTC4QxKlDDNo13iicurSK+oDbj3xlgUCpkZxlYb6iOnjS6gicA49pMO3K7A7NU9w8X1ypD691DyrZ7AjiOay6Nvg5ZHGe/L0x+TOnZtkp11tv8qid5UUNTZyDiw18pCdfDBOPWAVyU0fLuS540RICwsYZfYdnW08niv1OhZKgNCuY29w==
  • Delivered-to: cdi-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/cdi-dev/>
  • List-help: <mailto:cdi-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/cdi-dev>, <mailto:cdi-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/cdi-dev>, <mailto:cdi-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdlcTv8p1+lHALC7SxikReBCiihrWQ==
  • Thread-topic: TCK: Why are there two different ways to exclude tests?

Hello,

 

I was looking through TCK results in closer detail and noticed that there seem to be two different ways that tests are excluded in this TCK. Is that intentional for some reason, or should one mechanism be chosen for consistency?

3 tests are excluded in the tck-tests.xml files packaged in the TCK -- https://github.com/jakartaee/cdi-tck/blob/master/web/src/main/resources/tck-tests.xml & https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/resources/tck-tests.xml

 

2 more tests are excluded directly in the test code -- https://github.com/jakartaee/cdi-tck/blob/master/web/src/main/java/org/jboss/cdi/tck/tests/definition/bean/types/enterprise/illegal/BeanTypesWithIllegalTypeTest.java#L62 & https://github.com/jakartaee/cdi-tck/blob/master/impl/src/main/java/org/jboss/cdi/tck/tests/full/definition/bean/custom/CustomBeanImplementationTest.java#L143

 

Even though I recently updated one of the tck-tests.xml files, I actually prefer disabling them in the code and would probably have done so if I’d realized it was an acceptable option for this TCK.

 

-Brian

Back to the top