Re: [cargotracker-dev] (Review/approve PR)

[Gilbert Kwan <gkwan@xxxxxxxxxx>]

Hi Reza,

 

In my understanding from Chanun, there is a JSF implementation difference between Payara and Liberty. Payara is using Mojarra, and Liberty is using MyFaces. Chanun updated the following 3 files on the liberty-experimental branch that are favourite for MyFaces, so that Liberty does not show any warnings.

• src/main/webapp/WEB-INF/templates/common/admin.xhtml
• src/main/webapp/WEB-INF/templates/common/public.xhtml
• src/main/webapp/WEB-INF/web.xml

I cannot judge that the difference is MyFaces bug or Mojarra bug. I don’t see Payara or Liberty will change their implementation. To avoid the difference, Liberty can use Mojarra with the jsfContainer feature. That why I submitted the PR #231 that restores the above 3 files to original (same as master branch) and make Liberty to use Mojarra.

 

Hope it can clarify what the changes are.

 

Thanks

Gilbert

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Date: Wednesday, September 7, 2022 at 8:59 AM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cargotracker-dev] (Review/approve PR)

I looked at it, but honestly I am having trouble understanding the changes. One of the goals as an official Jakarta EE project is to highlight standards based implementation neutrality. Why is it necessary to switch to Mojarra? Are we running

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

I looked at it, but honestly I am having trouble understanding the changes. One of the goals as an official Jakarta EE project is to highlight standards based implementation neutrality. Why is it necessary to switch to Mojarra? Are we running into a MyFaces bug or do we have code that isn’t quite standard?

 

---

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Sent: Wednesday, September 7, 2022 8:49 AM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: Re: [cargotracker-dev] (Review/approve PR)

 

Hi Reza,

 

Do you have a chance to review and merge my PR https://github.com/eclipse-ee4j/cargotracker/pull/231?

 

Thanks

Gilbert

 

From: Gilbert Kwan <gkwan@xxxxxxxxxx>
Date: Tuesday, August 30, 2022 at 2:12 PM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: FW: [EXTERNAL] [cargotracker-dev] (no subject)

Hi Reza,

 

FYI, I signed the ECA.

 

Thanks

Gilbert

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Date: Friday, August 26, 2022 at 1:06 PM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] [cargotracker-dev] (no subject)

Hi Reza, I continue Chanun work. I just submitted a new PR to liberty-experimental with some updates, hoping that it can be merged soon. Enable Open Liberty to use jsfContainer feature and Mojarra library ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Hi Reza,

 

I continue Chanun work. I just submitted a new PR to liberty-experimental with some updates, hoping that it can be merged soon.

1. Enable Open Liberty to use jsfContainer feature and Mojarra library
2. Restore 2 xhtml and web.xml files to original

 

Thanks

Gilbert Kwan