| Re: [wakaama-dev] Wakaama Issues: endless-loop, IPv6 parsing |
Hi Julien,
I have been looking for the ] and then strip the [ and the ] off and then search on from there for the port. The way I was coding it, I was restricting it to IPv6 only, since that was what I needed. The more general solution might be a regexp as from https://tools.ietf.org/html/rfc3986#appendix-B .
Markus
From: wakaama-dev-bounces@eclipse.org [mailto:wakaama-dev-bounces@eclipse.org] On Behalf Of Julien Vermillard
Sent: Mittwoch, 25. Februar 2015 16:39
To: Wakaama developer discussions
Subject: Re: [wakaama-dev] Wakaama Issues: endless-loop, IPv6 parsing
Hi,
I think a bugzilla project exists on bugs.eclipse.org for Wakaama, but the mailing list is also fine :)
Github issues are disabled for eclipse projects (foundation policy).
Issue 1 was also found by a co-worker:
https://github.com/prieux/wakaama/blob/bootstrap/tests/client/object_security.c#L470
Should be fixed soon.
Issue 2 is a new one for me. I suppose for extracting the port we first, need to remove everything in the block "[..]" before looking for ":"
I suppose we also need to extract the IPv6 address from the [] block and remove the trailing '[' and ending ']'?
Julien
On Wed, Feb 25, 2015 at 10:25 AM Becker Markus <Markus.Becker@xxxxxxxxxxxx> wrote:
Hi,
since I only see Pull Requests being possible on github and no Issue tracking, let me report issues with wakaama here on the mailing list. If another location is more appropriate for issue reporting let me know.
Issue 1:
Endless loop in get_server_uri() in tests/client/object_security.c due to missing to move targetP to targetP->next. Works only if there is only one server object and that has the expected shortID.
char * get_server_uri(lwm2m_object_t * objectP,
uint16_t serverID)
{
security_instance_t * targetP;
targetP = (security_instance_t *)objectP->instanceList;
while (targetP != NULL)
{
if (targetP->shortID == serverID)
{
return strdup(targetP->uri);
}
+ targetP = targetP->next;
}
return NULL;
}
Issue 2:
prv_connect_server() in lwm2mcleitn.c fails to parse IPv6 addresses since it looks for : as a separator for the port.
Regards,
Markus
________________________________________________________ The contents of this e-mail and any attachments are confidential to the intended recipient. They may not be disclosed to or used by or copied in any way by anyone other than the intended recipient. If this e-mail is received in error, please immediately notify the sender and delete the e-mail and attached documents. Please note that neither the sender nor the sender's company accept any responsibility for viruses and it is your responsibility to scan or otherwise check this e-mail and any attachments.
_______________________________________________
wakaama-dev mailing list
wakaama-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wakaama-dev
________________________________________________________ The contents of this e-mail and any attachments are confidential to the intended recipient. They may not be disclosed to or used by or copied in any way by anyone other than the intended recipient. If this e-mail is received in error, please immediately notify the sender and delete the e-mail and attached documents. Please note that neither the sender nor the sender's company accept any responsibility for viruses and it is your responsibility to scan or otherwise check this e-mail and any attachments.
_______________________________________________
wakaama-dev mailing list
wakaama-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/wakaama-dev