Re: [viatra-dev] Wrong parameter reference in BatchTransformation.addRul

[Dávid István <davidi@xxxxxxxxxxxxxx>]

Sure thing. I'll create a patch as soon as I can. (Today or tomorrow.)

Cheers,
Steve

2013/9/22 Ujhelyi Zoltán <ujhelyiz@xxxxxxxxxx>

The original code was clearly bogus. Currently, the collection of rules is only used for initializing the pattern definitions before starting the rule engine, thus the problem was not visible through testing. Good catch (of course, the incremental case would need the set of rules for more reason).

The refactored version looks fine. Can you create a patch or a git commit to fix the original code (it may include the AbstractTransformationRule, but should not include the incremental rules yet), and we would then include it to the code base.

Cheers,
Zoli
-- Zoltán Ujhelyi
https://www.inf.mit.bme.hu/en/members/ujhelyiz

Fault Tolerant Systems Research Group
Budapest University of Technology and Economics

On 2013.09.22., at 9:06, Istvan Rath <rath@xxxxxxxxxx> wrote:

> The original code does seem bogus to me.
>
> The refactored version looks fine.
>
> Istvan
>
> --
> Istvan RATH, PhD
> Research fellow
> Budapest University of Technology and Economics
> Fault Tolerant Systems Research Group
>
>
>
> On Saturday, September 21, 2013 at 3:06 PM, Dávid István wrote:
>
>> Hi again,
>>

>> Got that part of the code refactored into an abstract super class: AbstractTransformation (https://github.com/david-istvan/viatra2-emf/blob/master/plugins/org.eclipse.viatra2.emf.runtime/src/org/eclipse/viatra2/emf/runtime/transformation/AbstractTransformation.java) and handled the issue. Please check whether I understood the purpose of that part or not.
>>
>> Cheers,
>> Istvan
>>
>>
>> 2013/9/21 Dávid István <davidi@xxxxxxxxxxxxxx (mailto:davidi@xxxxxxxxxxxxxx)>

>>> Hi,
>>>
>>> This one's for Zoli in the first place.
>>>
>>> http://git.eclipse.org/c/viatra2/org.eclipse.viatra2.emf.git/tree/plugins/org.eclipse.viatra2.emf.runtime/src/org/eclipse/viatra2/emf/runtime/transformation/BatchTransformation.java @79
>>>
>>> The variable shadowing ("rules") in the above mentioned method makes the assignment in line 80 quite meaningless for me. Could you please help me out with this?
>>>
>>> Regards,
>>> Istvan
>>
>> _______________________________________________
>> viatra-dev mailing list

>> viatra-dev@xxxxxxxxxxx (mailto:viatra-dev@xxxxxxxxxxx)
>> https://dev.eclipse.org/mailman/listinfo/viatra-dev

>>
>>
>
>
> _______________________________________________
> viatra-dev mailing list
> viatra-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/viatra-dev

_______________________________________________
viatra-dev mailing list
viatra-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/viatra-dev