Re: [ve-dev] Migrating to VE 1.2

[Rich Kulp <richkulp@xxxxxxxxxx>]

Hi, 

Sorry, we're busy releasing VE 1.2 and
also doing our new work and this note got lost in the shuffle. :-(

"Janak Mulani" <janak.mulani@xxxxxxxxx>
Sent by: ve-dev-bounces@xxxxxxxxxxx

06/26/2006 03:31 PM

Please respond to
Discussions people developing code for the Visual Editor project <ve-dev@xxxxxxxxxxx>

To	"ve-Dev@Eclipse. Org" <ve-dev@xxxxxxxxxxx>
cc
Subject	[ve-dev] Migrating to VE 1.2

Dear VE Team,

I downloaded VE 1.2 RC2 and compiled ULC VE against it.

I had the following issues:

1. Overrides

I migrated them using the tool and thanks for the tool.

2. CreationPolicy

This has now become IContainmentHandler. I also had a look at
LabelContainmentHandler and JLabel.override

I will change my CreationPolicy as per LabelContainmentHandler.

3. Compilation Errors:

- DefaultCopyEdtiPolicy: ctr takes EditDomain as arg now


- The method getWriteMethod(Statement) is undefined for the type
AbstractFeatureMapper

Could you please explain this change? Is getPropertyMethod(expr) the
replacement?

--- RLK Yes, use getPropertyMethod(Statement).


- Could you please explain the following API changes?

a. The return type is incompatible with
AbstractEMFContainerPolicy.getAddCommand(List, Object)
    (It overrides  AbstractEMFContainerPolicy.getAddCommand
which now takes
CommandBuilder as additional  arg and returns void)

b. The return type is incompatible with
AbstractEMFContainerPolicy.getOrphanTheChildrenCommand(List)
    (It overrides  AbstractEMFContainerPolicy.getOrphanTheChildrenCommand
which now takes CommandBuilder as additional  arg and returns void)

c. The return type is incompatible with
ContainerPolicy.getCreateCommand(Object, Object)
      (It overrides  AbstractEMFContainerPolicy.getCreateCommand
which now
takes CommandBuilder as additional  arg and returns void))

d. The return type is incompatible with
ContainerPolicy.getDeleteDependentCommand(Object)
   (It overrides  AbstractEMFContainerPolicy.getDeleteDependentCommand
which
now takes CommandBuilder as additional arg and returns void)

--- RLK We are now using CommandBuilders
to build up the commands. The reason the methods that return a Command
were made final is because is special code in place to handle the IContainmentHandler.
It makes sure that the IContainmentHandler gets a chance to intervene and
do the necessary modifications, including actually changing what is being
dropped to something else. To allow this to occur we now pass a command
builder around. You would build your command into the command builder instead
of generating it and returning it.

------------

I hope that after fixing the above errors ULC VE will run on VE 1.2. But,
I
would like to know if I should make any other changes in API usage to
benefit from the new efficiencies (could you please tell me if there are
any) in VE 1.2?

Thanks and regards,

Janak

_______________________________________________
ve-dev mailing list
ve-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ve-dev