Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [udig-dev] rethrow exception in EditManagerImpl#commitTransaction
That would be great :)
--
Jody Garnett


On Tue, 23 Oct 2018 at 07:36, Nikolaos Pringouris <nprigour@xxxxxxxxx> wrote:
Hi,

I am also aware of this issue a long tine ago. In my application I have modify EditManagerImpl so that when an exception is caught an  error MessageDialog is displayed to the user in both cases indicating a problem.
Moreover since in most of the cases espacially when dialing with database layers (I work with mysql layers) the problem is not recoverable (transaction is actually doomed) I resort in closing the transaction and initiating a new one.
I can submit a proposed PR for review th coming days if you think that this behaviour can be useful.

Στις Τρί, 23 Οκτ 2018 στις 4:55 μ.μ., ο/η Frank Gasdorf <fgdrf@xxxxxxxxxxxxxxxxxxxxx> έγραψε:

IMH the catched IOException should be re-thrown in commitTransaction() either

--
Frank


Am Di., 23. Okt. 2018 um 14:43 Uhr schrieb Loob, Sebastian <Sebastian.Loob@xxxxxxxxx>:

Hi all,

 

is there a particular reason, why the possible exception in method org.locationtech.udig.project.internal.impl.EditManagerImpl#commitTransaction() is not rethrown (line 406)?

Currently the surrounding application does not know whether or not the transaction was succesful.

 

So we suggest to rethrow the exception.

 

Sebastian


IBYKUS AG für Informationstechnologie, Erfurt / HRB 108616 - D-Jena / Vorstand: Helmut C. Henkel, Dr. Lutz Richter, Eckehart Klingner
Vorsitzender des Aufsichtsrates: Dr. Helmut Vorndran
_______________________________________________
udig-dev mailing list
udig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/udig-dev
_______________________________________________
udig-dev mailing list
udig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/udig-dev
_______________________________________________
udig-dev mailing list
udig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.locationtech.org/mailman/listinfo/udig-dev

Back to the top