Re: [udig-devel] Locationtech IP Review : ui.test bundle and containing

[Frank Gasdorf <fgdrf@xxxxxxxxxxxxxxxxxxxxx>]

OK, I let maven run tests twice, origin configuration and afterwards with removed jar's from lib folder mentioned earlier. I got the same test results for both, therefore I committed the changes: https://github.com/uDig/udig-platform/commit/61ec88fbeaa120bba916e6dd3de4ef0b4b0807b5

Outstanding task : How can we replace jmock jar's with bridge for junit3. I've seen a jmock bundle in the latest Orbit repository : org.jmock in version 1.2.0 whereas the local lib has version 2.3.0-RC1

I checked the dependencies and imports of org.jmock in other modules. Only one bundle has dependencies and only in one single class. I'm wondering whether we can replace this part with easymock. ui.test bundle iteself doesn't make use of jmock.

I'll investigate later ...

Cheers, Frank

2013/4/13 Frank Gasdorf <fgdrf@xxxxxxxxxxxxxxxxxxxxx>

Hello everybody,

I had a look at ui.test bundle with inner libs folder containing hamcrest.core and hamcrest.library jars. Have a look at the initial issue : https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7142 

I'm wondering why these libs are still in classpath and included in general because neither packages are exported nor used in the bundle itself.

My suggestion : remove libs and update .classpath files

In the future if we like to use hamcrest unit-test matchers we can reference hamcrest bundles coming from Eclipse Orbit Repository.

How about org.objenesis jar in the same bundle? Its in classpath but I couldn't find references (imports) in the bundle itself. Packages from this jar are not exported as well.

Las but not least : Same with cglib-nodep jar file. Added to classpath but no references in bundle itself, packages are not exported ether.

Would you agree to remove the following jars?

* lib/hamcrest-core-1.1.jar,

* lib/hamcrest-library-1.1.jar,

* lib/objenesis-1.0.jar

* lib/cglib-nodep-2.1_3.jar

 

 Are these libs maybe required by jmock having these libs in classpath at runtime? 

Thanks a lot,

Frank