| Re: [tractusx-dev] GitHub Pull Request reviews |
|
Hi all, I am seeing similar things on my end. Also very busy with PR reviews and creating IP issues for updated dependencies with the PRs. What I am encountering more and more is, that while fixing requested changes there are also new versions of 3rd party dependencies introduces.
This of course requires another set of IP issues.
As general information. IP issues that are create via dash have a due date of +1 week (currently). This is a (in my opinion) very fair amount of time that we must grant the EF team to investigate issues for us. This also means, that PRs with new IP issues are “delayed”. So please try to avoid updating dependencies on open PRs, as long as it is not necessary for fixing the findings
I hope you can understand, that the QG checks and PR reviews is a time consuming task for every committer, especially if PRs are not well prepared and the reviewing committer is not directly part of the product team. But still this is a crucial part in our release process. Maybe together we can come up with a better strategy/agreement/process, so that the topic isn’t becoming to frustrating for all sides and still guarantees proper quality. Best regards, Sebastian Mit freundlichen Grüßen / Kind regards Sebastian Bezold Software Engineer Mercedes-Benz Tech Innovation GmbH
(ehemals/formerly Daimler TSS GmbH) Wilhelm-Runge-Straße 11 89081 Ulm/Germany Sebastian.Bezold@xxxxxxxxxxxxxxxxx www.mercedes-benz-techinnovation.com
Mercedes-Benz Tech Innovation GmbH Sitz und Registergericht/Domicile and Register Court: Ulm, HRB-Nr./Commercial Register No.: 3844 Geschäftsführung/Management:
Daniel Geisel (Vorsitzender/Chairperson), Isabelle Krautwald Von:
tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> im Auftrag von "carsten.lenz--- via tractusx-dev" <tractusx-dev@xxxxxxxxxxx> [**EXTERNAL E-MAIL**]
Hi all, as you all know, we’re in the middle of QG4 checks for upcoming TractusX release 3.1. System Team is doing these checks based on Jira Ticket/GH Issues and findings are reported as GH Issues in Tractusx repositories. We
try to be as transparent as possible. Currently, I feel a bit offended and annoyed, and I will tell you why:
We as Consortia System Team Members put a lot of effort into these QG checks. If you open PRs to fix QG check findings, then please respect requested changes made by others and don’t merge PRs with changes requested.
Either discuss the requested changes with the requester or think about to implement the requested changes, there might be good reasons for.
If you ignore them, like in this case, you’ll have to open another PR potentially resulting in an additional release of your Application, Helm Chart or whatever - and you must deal with an annoyed System Team member and
read this kind of mails. Cheers Carsten -- Mit freundlichen Grüßen / Kind regards Carsten Lenz Senior Reliability Engineer Mercedes-Benz Tech Innovation (ehemals/formely Daimler TSS) Digital Value Platforms Wilhelm-Runge-Straße 11 89081 Ulm/Germany www.mercedes-benz-techinnovation.com
Mercedes Benz Tech Innovation GmbH Sitz und Registergericht/Domicile and Register Court: Ulm, HRB-Nr./Commercial Register No.: 3844 Geschäftsführung/Management: Daniel Geisel (Vorsitzender/Chairperson), Isabelle Krautwald
|
