Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [thym-dev] Discovery of Downloadable Cordova engines.

The fix for this is issue is now in, except the extension point. I have opened up an enhancement request [1] for it and will delay its implementation until we have real customers for it. 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=440831


On Mon, Jul 21, 2014 at 11:08 PM, Gorkem Ercan <gorkem.ercan@xxxxxxxxx> wrote:

On Mon, Jul 21, 2014 at 9:43 AM, Doug Schaefer <dschaefer@xxxxxxx> wrote:
My main concern is using extension points for this. What products are you talking about that would override this?

Who knows, hopefully many, perhaps one from QNX too ? As long as there has been Eclipse there has been products adopting Eclipse projects. JBoss tools, which is an adopter, has no current plans to use this extension point, I am simply suggesting it so that anyone providing modified Cordova versions or wants to limit the Cordova versions they cater would have a mechanism to do so.
 
I think we need to think of Thym as one thing and everyone gets the same no matter where it came from, which most likely will be eclipse.org.

You probably need to think of these things like p2 or maven repos. I have to assume the independent releases will have a dependency tree, especially being based on npm.

This is like p2 repos only difference is tool can only work with a single repo which can be customized by the extension point. Supporting multiple repos would be an overkill in the lack of a naming&versioning mechanism like OSGi provides for Cordova runtimes.

npm dependencies are avoided on purpose, even the cordova-cli [1] does not list Cordova-ios[2] (or any other platform) as a dependency. This way cordova-cli can only download the platforms (through npm APIs) that one uses instead of all the platforms that cordova supports. 

 

Doug.


From: thym-dev-bounces@xxxxxxxxxxx [thym-dev-bounces@xxxxxxxxxxx] on behalf of Gorkem Ercan [gorkem.ercan@xxxxxxxxx]
Sent: Monday, July 21, 2014 8:04 AM
To: Max Rydahl Andersen
Cc: Thym developer discussions
Subject: Re: [thym-dev] Discovery of Downloadable Cordova engines.

I wanted a larger discussion than bugzilla for this one but you are right bugzilla should receive this definition. 

The problem with auto detecting the minor version is on the long term if Cordova project start to do independent releases it will be possible to have a scenario as 

Cordova 4.0
    iOS 3.9.1
    Android 4.1
I can not think of auto detection mechanism for this scenario
--
Gorkem



On Mon, Jul 21, 2014 at 5:36 AM, Max Rydahl Andersen <manderse@xxxxxxxxxx> wrote:
On 19 Jul 2014, at 21:02, Gorkem Ercan wrote:

Due to bug 439650 [1], we need to change the way we discover downlodable
Cordova engines. At the moment we make the assumption that all Cordova
Engines for all platforms share the same version for a particular Cordova
version. Although this is usually the case, it is not always true (as seen
on the bug report). Furthermore, Cordova project is discussing to make
platforms make releases more independently.  Also there is an ongoing
experiment to provide Cordova downloads through npm which may eventually
cause us to adjust download locations for some versions.

So my proposal is to introduce a new extension point that provides the
downloadable Cordova Engine information. Basically,a collection of cordova
versions, with included platform library versions and download URLs.  The
default implementation of the extension point will be provided by Thym and
will provide the information for distros from Cordova project. And in order
to be able to catch up with Cordova releases (without the need for Thym
releases) the plan is to make the implementation retrieve the info from a
json file hosted in our repo.

I am also planning to make the extension point overwritable by products. So
if an adopter of Thym wants to use its own engines, it would be possible.

I should be able to push an early implementation soon, in the meanwhile any
concerns, questions are welcome.


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=439650

not sure if you wanted the feedback here or on the bug - your description above should be on the bug :)

anyhow no matter if you have an external description of "cordova releases" which I reckon
will say something like:

cordova 3.4.0:
   ios 3.4.0
   android 3.4.0

cordova 3.4.1:
   ios 3.4.1
   android 3.4.0


wouldn't it be good that the tooling simply took these as advises but if lets say an ios 3.4.2 becomes available
the tooling would still allow you to pick that up and use it no matter if this externally defined descrption have
been updated or not ?


/max
http://about.me/maxandersen


_______________________________________________
thym-dev mailing list
thym-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/thym-dev



Back to the top