Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [servlet-dev] Release staged 5.0.0 to Maven Central
Mark,
I just have to smile... These are some of the exact reasons why some of us didn't want to re-open this can of worms.  What sounds like an "easy" task needs to be discussed, vetted, and approved before we can start making these type of decisions.  All that I was doing was relaying some of the conversation from this morning's Platform call and the ".api" suffix had a thumbs down on the call.  Mainly because the project itself and the associated api is already known as an "api".  So, providing the "api" suffix seemed superfluous.  For example, will there every be a "jakarta.servlet.impl" module?  Probably not.  Jakarta produces APIs, not Impls.

I think everyone is in agreement that "java.servlet" is not correct as the automatic module name.  The simple update is to rename this to "jakarta.servlet" -- just to correct the "java" prefix error.

Now, if you decide to include the ".api" suffix, you are probably no more right or no more wrong than anything else the other projects have chosen because we don't have a complete answer for the module naming convention yet.

Which is making me come to the conclusion that we should stick to our original premise that we're not going to be concerned with "proper" modules names in Jakarta EE 9.  They don't apply to Java SE 8 -- which we just decided is our first priority.  When we decide to support Java SE 11, then we can have the full-blown conversation about the naming convention.  I'll start this thread on the Platform and Spec Project Leads mailing list so that we can (hopefully) close on it in short order.

Thanks, Mark, for the input!

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn: https://www.linkedin.com/in/kevinwsutter



From:        Mark Thomas <markt@xxxxxxxxxx>
To:        servlet-dev@xxxxxxxxxxx
Date:        07/21/2020 13:22
Subject:        [EXTERNAL] Re: [servlet-dev] Release staged 5.0.0 to Maven Central
Sent by:        servlet-dev-bounces@xxxxxxxxxxx



On 21/07/2020 18:25, Kevin Sutter wrote:
> Mark,
> What other naming conventions are you referring to?  The discussion on
> the call is that the trailing ".api" on some of the other proposed
> module names was wrong and should be removed.

On what basis?

Naming conventions are documented here:
https://wiki.eclipse.org/JakartaEE_Maven_Versioning_Rules

That explicitly states JPMS module names are excluded.

The most recent discussion of JPMS names of which I am aware is this one:
https://www.eclipse.org/lists/jakartaee-spec-project-leads/msg00389.html

If a formal decision has been made on JPMS names since then I don't
recall seeing it. Given the lists I am subscribed to I would have
expected to see any proposed naming policy and/or discussion about said
policy and/or announcement of such policy.

Absent a formal decision, my recommendation continues to be "Take the
OSGI symbolic name and replace any "-" with ".". For servlet that gives
"jakarta.servlet.api"

Mark



 For example, jsp and el
> were identified as having this ".api" suffix.  
>
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Jakarta EE architect @ IBM
> e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
> phone: tl-553-3620 (office), 507-253-3620 (office)    
> LinkedIn: https://www.linkedin.com/in/kevinwsutter
>
>
>
> From:        Mark Thomas <markt@xxxxxxxxxx>
> To:        servlet-dev@xxxxxxxxxxx
> Date:        07/21/2020 11:40
> Subject:        [EXTERNAL] Re: [servlet-dev] Release staged 5.0.0 to
> Maven Central
> Sent by:        servlet-dev-bounces@xxxxxxxxxxx
> ------------------------------------------------------------------------
>
>
>
> On 21/07/2020 17:29, arjan tijms wrote:
>> Hi,
>>
>> I was looking at the spreadsheet already. I'll do a PR for
>> "jakarta.servlet" then.
>
> jakarta.servlet.api would be consistent with the other naming conventions.
>
> Mark
>
>
>>
>> Kind regards,
>> Arjan
>>
>> On Tue, Jul 21, 2020 at 6:21 PM Kevin Sutter <sutter@xxxxxxxxxx
>> <mailto:sutter@xxxxxxxxxx>> wrote:
>>
>>     Hi,
>>     As an FYI, I just posted this to the Specification PR for Servlet
>>     5.0
>>     (https://github.com/jakartaee/specifications/pull/232#issuecomment-661953843):
>>
>>     _@arjantijms_ <https://github.com/arjantijms>, on the _Platform call
>>     today_
>>     <https://docs.google.com/document/d/1EJ2ilaPhMnQqa3aw6AmwjRbBPGL3_np4uuwklgfqPZI/edit#>,
>>     we discussed the Automatic Module names. We discovered a couple of
>>     components that have an "incorrect" automatic module name specified.
>>     Servlet is one of them. In the _servlet api pom file_
>>     <https://github.com/eclipse-ee4j/servlet-api/blob/master/api/pom.xml>,
>>     it is generating an automatic module name of "java.servlet". To be
>>     consistent with the package name update, this should be
>>     "jakarta.servlet". There is an active discussion whether these type
>>     of updates need to be done for Jakarta EE 9 or not. For these cases
>>     where the javaprefix is being used instead of jakarta, I think they
>>     should be.
>>     This would require a respin of the Servlet 5.0.0 API jar file.
>>     FYI, besides Servlet, we have also found Transactions,
>>     Authentication, and Authorization in the same boat. There may be
>>     more. _@keilw_ <https://github.com/keilw>is continuing the
>>     investigation by updating _this spreadsheet_
>>     <https://docs.google.com/spreadsheets/d/1g8jYG0JixO3wzZkpeyU1LMIQRhbnZ76kGtdMFE8mieE/edit#gid=0>.
>>
>>     Thanks.
>>
>>     ---------------------------------------------------
>>     Kevin Sutter
>>     STSM, MicroProfile and Jakarta EE architect @ IBM
>>     e-mail:  sutter@xxxxxxxxxx <mailto:sutter@xxxxxxxxxx>     Twitter:
>>      @kwsutter
>>     phone: tl-553-3620 (office), 507-253-3620 (office)    
>>     LinkedIn: https://www.linkedin.com/in/kevinwsutter
>>
>>
>>
>>     From:        arjan tijms <arjan.tijms@xxxxxxxxx
>>     <mailto:arjan.tijms@xxxxxxxxx>>
>>     To:        servlet developer discussions <servlet-dev@xxxxxxxxxxx
>>     <mailto:servlet-dev@xxxxxxxxxxx>>
>>     Date:        07/21/2020 10:34
>>     Subject:        [EXTERNAL] Re: [servlet-dev] Release staged 5.0.0 to
>>     Maven Central
>>     Sent by:        servlet-dev-bounces@xxxxxxxxxxx
>>     <mailto:servlet-dev-bounces@xxxxxxxxxxx>
>>     ------------------------------------------------------------------------
>>
>>
>>
>>     Hi,
>>
>>
>>
>>     On Tue, Jul 21, 2020 at 4:31 PM Mark Thomas <_markt@apache.org_
>>     <mailto:markt@xxxxxxxxxx>> wrote:
>>
>>     Agreed.
>>
>>     I'm going to assume there aren't going to be any objections and start
>>     work on a PR.
>>
>>
>>
>>     Okay, great! I'll keep an eye out on that and will restage 5.0.0
>>     then and re-run the TCK.
>>
>>     Thanks!
>>
>>     Kind regards,
>>     Arjan
>>
>>      _______________________________________________
>>     servlet-dev mailing list
>>     servlet-dev@xxxxxxxxxxx <mailto:servlet-dev@xxxxxxxxxxx>
>>     To unsubscribe from this list, visit
>>     https://www.eclipse.org/mailman/listinfo/servlet-dev
>>
>>
>>
>>     _______________________________________________
>>     servlet-dev mailing list
>>     servlet-dev@xxxxxxxxxxx <mailto:servlet-dev@xxxxxxxxxxx>
>>     To unsubscribe from this list, visit
>>     https://www.eclipse.org/mailman/listinfo/servlet-dev
>>
>>
>> _______________________________________________
>> servlet-dev mailing list
>> servlet-dev@xxxxxxxxxxx
>> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev
>>
>
> _______________________________________________
> servlet-dev mailing list
> servlet-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/servlet-dev
>
>
>
>
>
> _______________________________________________
> servlet-dev mailing list
> servlet-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev
>

_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev




Back to the top