Re: [riena-dev] Target Milestone reminder / DecimalTextRidget questions

[ekkehard <ekkehard@xxxxxxxxxxxxxxxxx>]

Elias Volanakis schrieb:

Hi Rienaers,

a couple of comments and questions:

1. Quick reminder: please remember to set the Target Milestone to '1.1.0.M7' if you resolve bugs in bugzilla. This allows us to create a list of fixed issues for the next new and noteworthy .

Two things about DecimalTextRidget; maybe you can provide some guidance how this was handled in the predecessor of Riena:

I dont know the predecessor, but what I would expect:

2. What should happen when the precision is less than the digits after comma on setText / updateFromModel ?

r.setPrecision(2);

r.updateFromModel(); // 3,1415 

results in?

this should be an error if the values could be entered into the field
in a read-only field it doesnt matter

If we allow this into the control, then the next question is how does the text control behave, because we don't allow intermediate illegal values, such as 3,141

3. What should happen when mandatory is 'on' on the DecimalTextRidget? Was that something that was possible in the past? Right now it the Decimal Ridget not support an empty value, so 0 / 0,(0...0) is considered empty. Do we want to allow an empty (',') value?

for me 0..... sounds better - a ',' only doesnt look well

4. I noticed that some re-exports have sneaked into the following bundles. In my opinion we should limit re-exports to *client* / *server* / org.eclipse.riena.core. See suggestions below.

+1 re-exports please only at *clien* or *server*

ekke ...from JAX

org.eclipse.riena.monitor.common

15: com.caucho.hessian;bundle-version="3.1.3";visibility:=reexport,

// can be removed without compile rrors

org.eclipse.riena.ui.ridgets.swt

21: org.eclipse.nebula.widgets.compositetable;bundle-version="1.0.0";visibility:=reexport  

// should be re-exported by org.eclipse.riena.client and org.eclipse.riena.client.ridgets instead

org.eclipse.riena.ui.swt

8: org.eclipse.equinox.log;bundle-version="1.1.0";visibility:=reexport,  

// can be removed without compile errors

Greetings from Portland,

Elias.

--
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com

_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev
  

--

ekkehard gentz
software-architect
erp-consultant
max-josefs-platz 30, D-83022 rosenheim, germany
homeoffice (1+1 VoIP): +49 8031 2068 325
mobile (iPhone): +49 151 19424929
mailto:ekkehard@xxxxxxxxxxxxxxxxx
homepage: http://www.gentz-software.de
opensource: http://ekkehard.org
blog (en): http://ekkes-corner.org
blog (de): http://ekkes-ecke.org
skype: ekkes-corner
Steuer-Nr: 156/220/30931 FA Rosenheim, UST-ID: DE189929490