Re: [ptp-dev] changes to pbs plugins

[Roland Schulz <roland@xxxxxxx>]

On Mon, Nov 8, 2010 at 3:40 PM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:

On Nov 8, 2010, at 3:20 PM, Benjamin Lindner wrote:

> I put the PBSAttributes and the Reader Classes into the pbs.core space because it makes sense. They are not a functionality of the proxy, but depend on the PBS specifications and command line tools. Currently the proxy server has hardcoded the command line parameters, but this will eventually be outsourced into a file, which also could be put into the pbs.core namespace.

But is only used by the proxy right? The pbs.core classes are for the client-side RM implementation, so anything that goes in here should be used by the client side at least.

>
> Why does the proxy server jar file get placed into pbs.core in the first place?
> Wouldn't it make more sense to put the proxy server jar file into the jproxy directory?

That's where it was originally, and is my preferred location, however it got moved due to dependency problems with proxy. See bug 319203 for details. Roland, I assume that this is still the situation, or is it possible to move the proxy back into the jproxy plugin?

I wrote in the bug:

For the dependencies I had to move PBSProxyServerRunner out of .rm.pbs.jproxy
and I moved it into .rm.pbs.core. Because of that the
org.eclipse.ptp.rm.pbs.PBSProxyServer extension point also had to be moved
because otherwise the class wasn't found. Without any other change the payload
isn't found. 
There are two options:
- Reference the payload from the jar file in the other plugin. Is this
possible? 

- Move the payload also to .rm.pbs.core. 

I think it makes no sense that PBSProxyServerRunner was in .rm.pbs.jproxy, because it is the client code and not the server code, thus I think this change was good (also it would still cause dependency problems). 

But may be the other option would have been the better one. Is it possible to have PBSProxyServerRunner  in core but the payload jar in jproxy? Thus it is possible to configure the extension point in the way that it find the jar file in a different plug-in?

Roland

>
> Sorry for my confusion,
> ben
>
>
> On Nov 8, 2010, at 10:31 AM, Greg Watson wrote:
>
>> Currently the org.eclipse.ptp.rm.pbs.jproxy plugin depends on org.eclipse.ptp.rm.pbs.core, which means that rm.pbs.core gets built first. However, the jproxy build creates the proxy server jar file which needs to be copied into the rm.pbs.core plugin *before* it is built. The result is that the proxy server jar is currently missing from the 5.0 builds.
>>
>> I'd like to reorganize the PBS plugins slightly as follows:
>>
>> 1. Move the PBSAttributes directory to org.eclipse.ptp.rm.pbs.jproxy. They are only used by the proxy, so this is a more logical location.
>>
>> 2. Remove the dependency on org.eclipse.ptp.rm.pbs.core from org.eclipse.ptp.rm.pbs.jproxy. This requires moving the classes in org.eclipse.ptp.rm.pbs.core.parser (AttributeDefinitionReader, etc.) to the jproxy plugin. These classes also only seem to be used by jproxy so this shouldn't affect anything else. The plugin dependencies will then be:
>>
>> org.eclipse.ptp.core
>> org.eclipse.ptp.rm.proxy.core
>> org.eclipse.ptp.proxy.protocol
>> com.ibm.icu.text.DateFormate
>>
>> 3. Create a new plugin called org.eclipse.ptp.rm.pbs.core.server that will contain the proxy server jar. I would rather it be in it's own plugin than in the pbs.core plugin.
>>
>> Please let me know asap if this will cause any problems.
>>
>> Thanks,
>> Greg
>> _______________________________________________
>> ptp-dev mailing list
>> ptp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

-- 
ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
865-241-1537, ORNL PO BOX 2008 MS6309