[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ptp-dev] changes to pbs plugins
|
I put the PBSAttributes and the Reader Classes into the pbs.core space
because it makes sense. They are not a functionality of the proxy, but
depend on the PBS specifications and command line tools. Currently the
proxy server has hardcoded the command line parameters, but this will
eventually be outsourced into a file, which also could be put into the
pbs.core namespace.
Why does the proxy server jar file get placed into pbs.core in the
first place?
Wouldn't it make more sense to put the proxy server jar file into the
jproxy directory?
Sorry for my confusion,
ben
On Nov 8, 2010, at 10:31 AM, Greg Watson wrote:
Currently the org.eclipse.ptp.rm.pbs.jproxy plugin depends on
org.eclipse.ptp.rm.pbs.core, which means that rm.pbs.core gets built
first. However, the jproxy build creates the proxy server jar file
which needs to be copied into the rm.pbs.core plugin *before* it is
built. The result is that the proxy server jar is currently missing
from the 5.0 builds.
I'd like to reorganize the PBS plugins slightly as follows:
1. Move the PBSAttributes directory to
org.eclipse.ptp.rm.pbs.jproxy. They are only used by the proxy, so
this is a more logical location.
2. Remove the dependency on org.eclipse.ptp.rm.pbs.core from
org.eclipse.ptp.rm.pbs.jproxy. This requires moving the classes in
org.eclipse.ptp.rm.pbs.core.parser (AttributeDefinitionReader, etc.)
to the jproxy plugin. These classes also only seem to be used by
jproxy so this shouldn't affect anything else. The plugin
dependencies will then be:
org.eclipse.ptp.core
org.eclipse.ptp.rm.proxy.core
org.eclipse.ptp.proxy.protocol
com.ibm.icu.text.DateFormate
3. Create a new plugin called org.eclipse.ptp.rm.pbs.core.server
that will contain the proxy server jar. I would rather it be in it's
own plugin than in the pbs.core plugin.
Please let me know asap if this will cause any problems.
Thanks,
Greg
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
