On Mon, Nov 8, 2010 at 10:31 AM, Greg Watson
<g.watson@xxxxxxxxxxxx> wrote:
Currently the org.eclipse.ptp.rm.pbs.jproxy plugin depends on org.eclipse.ptp.rm.pbs.core, which means that rm.pbs.core gets built first. However, the jproxy build creates the proxy server jar file which needs to be copied into the rm.pbs.core plugin *before* it is built. The result is that the proxy server jar is currently missing from the 5.0 builds.
I'd like to reorganize the PBS plugins slightly as follows:
1. Move the PBSAttributes directory to org.eclipse.ptp.rm.pbs.jproxy. They are only used by the proxy, so this is a more logical location.
2. Remove the dependency on org.eclipse.ptp.rm.pbs.core from org.eclipse.ptp.rm.pbs.jproxy. This requires moving the classes in org.eclipse.ptp.rm.pbs.core.parser (AttributeDefinitionReader, etc.) to the jproxy plugin. These classes also only seem to be used by jproxy so this shouldn't affect anything else. The plugin dependencies will then be:
org.eclipse.ptp.core
org.eclipse.ptp.rm.proxy.core
org.eclipse.ptp.proxy.protocol
com.ibm.icu.text.DateFormate
It also depends on org.eclipse.ptp.utils.core and org.eclipse.osgi.util.NLS.
3. Create a new plugin called org.eclipse.ptp.rm.pbs.core.server that will contain the proxy server jar. I would rather it be in it's own plugin than in the pbs.core plugin.
Please let me know asap if this will cause any problems.
To me these changes look good and shouldn't cause a problem. But since Ben did this he should comment.
@Ben: Any particular reason why you put those classes in pbs.core and why moving them would not be good?
Roland
