Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ptp-dev] Adding/replacing environment variables on remote processes

Hi,

While I was investigating bug #239251, I see that the parallel launcher creates environment variables that inherit on the local environment if the "append" option is enabled in the launcher tab. This does probably not make sense if the process is running on a remote host.

In order to address this issue, I am considering following fixes, and would like your feedback before going on with changes.

1) The AbstractParallelLaunchConfigurationDelegate.getAttributeManager(...), instead of calling DebugPlugin.getDefault().getLaunchManager().getEnvironment(configuration), creates the array of environment variables by itself. In case of "appending" the environment, queries the IRemoteConnection for default environment variables of the remote host, that are then added to the array.

This means changing the IRemoteConnection interface to support this quey. I wonder if this is the right place for the new method. Also, implementors of IRemoteProcess must ensure that they do not inherit the remote environment (as RemoteTools currently does).

2) Change the interface of IRemoteProcessBuilder to add a method that enables/disables inheriting remote environment. The launcher would the use a new JobAttribute to signal to the RuntimeSystem if the new Job should "append" or "replace" environment variables on the remote host.

Best regards,
Daniel Felix Ferber


Back to the top