[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ptp-dev] Question about AbstractRMLaunchConfigurationDynamicTab.performApply
|
Dave,
On the first case, I'm afraid that seems to be the correct process.
I'm calling the method that updates the buttons, it in turn, calls
the performApply() that calls your performApply(). I must update
the state of the buttons to reflect the validity of the input.
About the second item, I think this is correct, though the newest
behavior of setSelection() on a combo box has been changed to not
call the selection listener... Go figure. I think the latter is
a recently introduced bug. I haven't looked at it later, maybe
its been fixed in the very latest release of SWT.
Regards,
Randy
On Thu, 2007-06-14 at 13:20 -0400, Dave Wootton wrote:
> I've changed my implementation of AbstractRMLaunchConfigurationDynamicTab
> to register a ModifyListener on my Text and Combo widgets instead of using
> a FocusListener, and think I have it working correctly. I've noticed some
> behavior I wasn't expecting, and just want to be sure that I have things
> working correctly.
>
> My main validation method gets called in response to a ModifyEvent. It
> validates all fields and calls fireContentsChanged() once validation is
> complete, in order to ensure any error message gets displayed. This seems
> to invoke some internal Eclipse processing which invokes my performApply()
> method, where, following the ORTE implementation's model, I store all
> attribute values into the launch configuration. So the result is that,
> since fireContentsChanged() is invoked on every keystoke, I'm saving
> launch configuration values at every keystroke, even when fields have
> invalid contents. I can see where this might be required so that if I
> switch from the parallel tab to another tab, then come back to the
> parallel tab, the values that were last entered in the parallel tab are
> still there.
>
> I also noticed that if I call setText() on a Text or Combo widget that has
> a ModifyListener registered, that the ModifyListener gets invoked as a
> result of the setText() call. Is that expected SWT behavior?
>
> Thanks
>
> Dave
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
