Re: [platform-ui-dev] Functional difference between WorkingSetSelectionD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog

From: Mickael Istria <mistria@xxxxxxxxxx>
Date: Fri, 11 Apr 2014 14:42:47 +0200
Delivered-to: platform-ui-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/platform-ui-dev>
List-help: <mailto:platform-ui-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/platform-ui-dev>, <mailto:platform-ui-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/platform-ui-dev>, <mailto:platform-ui-dev-request@eclipse.org?subject=unsubscribe>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 04/11/2014 02:36 PM, Paul Webster wrote:

Wouldn't it need a lot of code to make it launch with the 2 modes (simple or normal)?

As far as I can see, not much is needed.
We could just add another constructor to the SimpleWorkingSetSelectionDialog which would allow to enable the filter or not, and replace all instantiations and references to the WorkingSetSelectionDialog by SimpleWorkingSetSelectionDialog.

If you're not aware of any potential pitfalls, I'll create a bug and hopefully provide a patch.

--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

Follow-Ups:
- Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
  - From: Paul Webster

References:
- [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
  - From: Mickael Istria
- Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
  - From: Paul Webster

Prev by Date: Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
Next by Date: Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
Previous by thread: Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
Next by thread: Re: [platform-ui-dev] Functional difference between WorkingSetSelectionDialog and SimpleWorkingSetSelectionDialog
Index(es):
- Date
- Thread

Breadcrumbs