Re: [platform-releng-dev] Heads up: org.eclipse.compare pom in needs upd

[David M Williams <david_williams@xxxxxxxxxx>]

You suggests deserve to be part of this
discussion, but I will point out a few extra considerations. 

A. The change that "broke"
the I-build in question was done after the previous N-build ... or else
would have shown up there, and given some possibility of being fixed before
the I-build. So ... the question of whether to respin (or, immediately
fail) an I-build, would still remain. 

B. More important, I think our "philosophy"
has always been to "build and tests as much as possible" each
build, since often there is more than one problem, and if we fixed them
"serially", one at a time ... it'd take too long to get out a
good build.  I think this is always true of any "large"
project ... especially one that has too few worldwide committers to "fix
quickly" all issues found in one build. I'm not saying that that philosophy
can't change ... just explaining one of the reasons we don't like to "fail
on first error''. 

But, thanks for the suggestions. They
deserve more thought and discussion. 

To give a little more history of this
particular "magic script" ... it was originally put in place
and conceived (by people smarter than me) to possibly someday "automatically
commit" the change in the POM it found was needed. This idea was "vetoed"
by some committers since they didn't think the build should commit any
substantial changes to a committer restricted project ... after all, who's
to say if the change it found to continue the build is the right one? Maybe
the Manifest was mistakenly changed? Maybe POM was correctly changed and
it is the Manifest.mf that needs to be have its version changed ... both
unlikely ... but, just hard to know for sure without a committer looking
at it. 

Thanks again, 





From:      
 Mickael Istria <mistria@xxxxxxxxxx>
To:      
 platform-releng-dev@xxxxxxxxxxx,

Date:      
 07/05/2013 04:00 AM
Subject:    
   Re: [platform-releng-dev]
Heads up: org.eclipse.compare pom in        needs
updating
Sent by:    
   platform-releng-dev-bounces@xxxxxxxxxxx

---

Hi all,

It seems to me that the magic script that fixes the pom files at build-time
does too much magic to ensure other flavors of the Platform Build (such
as the one I've tried) work well.
Let's imagine this magic script wouldn't run, what would have been the
scenario?
1. Someone commits a change in MANIFEST.MF and forgot it in pom.xml
2. Nightly build would have failed because MANIFEST.MF and pom.xml are
not in sync
3. A bug would have been opened and would have been fixed quickly (because
fix is trivial, and since it prevents the build to run usually makes it
fixed faster)
4. Next Nightly is OK
5. An I-Build is triggered for a commit that built successful as a nightly,
so it should work.
6. Aggregated repo gets updated
7. Consumers of aggregated repo have something that works.

Pro: External build always work
Cons: 1 nightly is lost

I understand and agree that having to edit both MANIFEST and pom is annoying.
However, it's a requirement for build to work, and not having them in sync
is a bug. Having this script to change automatically pom almost hides this
bug so that aggregated repo consumers can have failures.

Cheers,
-- 
Mickael Istria
Eclipse developer at JBoss,
by Red Hat
My
blog - My
Tweets_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev