When discussing improving the p2 target locations, our preferred solution was an edit wizard similar to what you suggest. The main problems were 1) that the UI borrowed from p2 only allowed a single url (you can work around this by adding multiple p2 locations and they will resolve together) and 2) It was difficult or impossible to edit/remove/update the selected IUs (you can somewhat work around this using the remove and update buttons in the target editor). A different edit wizard that listed the urls and IUs separate, allowed them to be added/removed and the 'include required' etc. settings changed was the preferred solution, but not one PDE had time to work on.
Curtis
Mickael Istria ---02/07/2014 01:35:01 AM---On 02/06/2014 07:58 PM, Curtis Windatt wrote: >
From: Mickael Istria <mistria@xxxxxxxxxx>
To: pde-dev@xxxxxxxxxxx,
Date: 02/07/2014 01:35 AM
Subject: Re: [pde-dev] [Target Platform editor] What's this update button?
Sent by: pde-dev-bounces@xxxxxxxxxxx
On 02/06/2014 07:58 PM, Curtis Windatt wrote:
1) The update button currently is only supported by the p2 software site target locations. It provides a quick way to change the version of installable units included in the target. Doing this without the button required editing the location, unslecting the previous version and selecting the new version, then repeating for each location. Since the UI workflow for editing p2 locations is limiting, the button serves a useful purpose. If you have suggestions on how to make its purpose more clear, absolutely we would consider them.
Ok, thanks for the note.
It's indeed very useful. I wrote a Maven Mojo which does that. Maybe I should have been more curious and tried this update button before ;)
About a workflow, I find it a bit strange because in order to make this button useful, one already has to change the URL before this button become useful. Instead, I'd suggest that when clicking "Edit" on a p2 location, the first page to show up could be a wizard that would ask whether user wants to:
* "Change repository URL and update versions of current Installable Units". In this case, user would set an URL, click Next and see the suggested changes in the next page. Clicking Finish would apply the change.
* "Add or Remove Installable Units". In this case, Next page would show the current "Edit..." page where user can select some IUs.
WDYT?
2) I think this would be an improvement, as long as the user doesn't see the "re-load" button and assume the target platform has already been updated with the changes they made.
Actually, it wouldn't be a re-load button, it would be an alternative Link label to "Set target-platform".
Reported in https://bugs.eclipse.org/bugs/show_bug.cgi?id=427624
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
|