| Re: [papyrus-rt-dev] RSA Import |
Hi,Some comments inline below./Peter CigéhnOn 26 January 2017 at 20:30, Ernesto Posse <eposse@xxxxxxxxxxxxx> wrote:Hi. I'm not sure if this counts as a bug, but while importing a model from RSA I noticed something about the diagrams. First, the diagram icons are the old ones:And second, the diagrams themselves seem to "preserve" (to a degree) the look of RSA diagrams:I wonder if you actually have the RSARTE specific extension in Papyrus-RT installed, or if you only have used the base RSA import from Papyrus?If you check your installed software, do you have the RSARTE importer installed? If you do not have the RSARTE importer installed, then you would get the
behavior you are seeing, i.e. the structure diagram and the state-machine diagram will be imported with the standard Papyrus viewpoint and viewtype. You need the RSARTE importer to ensure that the diagrams get imported with the UML-RT specific viewpoints and viewtypes. This was once fixed as part of https://bugs.eclipse.org/bugs/show_bug.cgi?id=495580 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=495572, so that should work now.It is not that obvious when using the import as such, since it is still referred to as RSA import, and the wizard looks exactly the same. The RSARTE specific extension of the import only "hooks in" behind the scene, and the UI and wizard looks exactly the same. So this might be what causes the confusion.Is the intention to preserve the exact look and feel of RSA diagrams? I get the feeling that some visual properties are preserved (some colours), but not others (fonts, background), while transition labels are missing, RTState and RTPseudostate stereotype names are present (and shouldn't) and there is an obvious problem with the size of the diagram in its context (which could be specific to macOS, but I don't know). So the resulting look is quite inconsistent. Is this an issue to be addressed?Yes, the intention with the import is to try to preserve as much look-and-feel as that of the RSA(RTE) diagram. But just to be clear, the import to state-machine diagrams, especially with the aspect of importing RSARTE state-machine diagrams, has not really been tested that much. I for sure, have spent close to no time testing the import of state-machine diagrams in Papyrus-RT, especially since we are still working (as we speak) with the customization of the state-machine diagrams for Papyrus-RT. So it has been a bit pre-mature to test the import and check the layout of state-machine diagrams when we are not finished with the basic functionality in Papyrus-RTRegarding the missing labels, that seem to be a rather recurring issue with lots of diagram types, not only state-machine diagrams. I have written a few bugs related to both structure diagrams and activity diagrams, which also misses labels for different kinds of elementsI am also about to write another one for missing port labels on inherited ports, but have not had the time to do so yet. This will be the first import bug related to inheritance, now when we are starting to get the inheritance functionality in place and I have started to test that a little bit.So I am not surprised that the labels are missing in the state-machine diagram also. There is also some aspects to consider here, since in RSA(RTE) there is only one label for a transition which, potentially, could display both the transition name, the guard, and the effect, for that transition. Whereas in Papyrus, the approach is two separate labels (Rémi is working on CSS customizations regarding this). So there is possibly some care needed regarding this. But on the other hand, you normally never use this about showing the guard and effect directly in a label in RSARTE, since it becomes too cluttered. So we can probably disregard from this mapping problem, and only consider the transition name label.
Regarding the stereotypes that is shown, I guess that is related to the first issue, that you actually only have imported the model using the RSA importer,
and thus have gotten the wrong viewpoint/viewtype for the diagrams, and hence also have not gotten the Papyrus-RT specific customizations on the diagram. I assume that we have customized the state-machine diagram in Papyrus-RT using CSS to hide those superfluous stereotypes.
_______________________________________________So the issues you are seeing are two-fold: Wrong importer have been used, and some additional not-yet-tested-and-addressed issues with the layout of state-machine diagrams.
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
