| Re: [papyrus-rt-dev] Failing builds |
So the problem was actually the version number of the plugin. Interestingly enough, I didn't need to add the designer common feature for the build to pass (why?)Anyway, it's ready to submit once change change 84214 is submitted.PS: I gave my change a +2 and the submit button is enabled, but its parent (the latest commit in 84214) is not merged. If I were to click on the submit button would it submit both changes or give an error that it cannot be submitted until it's parent is submitted?On Mon, Oct 31, 2016 at 10:58 AM Ernesto Posse <eposse@xxxxxxxxxxxxx> wrote:Thanks for taking care of this so quickly!It looks like my change is failing on the Codegen job but the problem seems to be with Papyrus Designer.It looks like we are missing the 'base' feature of Designer.In the 'common' tpd we have// Required for building Codegen and Cpp
location "http://download.eclipse.org/
modeling/mdt/papyrus/ " eclipse-papyrus-designer-neon {components/designer/1.0.1_ papyrus-designer-neon_133/ org.eclipse.papyrus.designer.
languages.cpp.feature.feature. group }
but codegen also uses the org.eclipse.papyrus.designer.languages.common. plugin which is in org.eclipse.papyrus.designer.base languages.common.feature. feature.group. I'll add it to the patch. I'm surprised that the Codegen builds worked before, though.--Ernesto PosseZeligsoftOn Mon, Oct 31, 2016 at 10:19 AM Philip Langer <planger@xxxxxxxxxxxxxxxxx> wrote:Hi Ernesto,I've finalized the patch switching to the integration build of EMF Compare / EGit. It was indeed the problem that the version of the EMF Compare feature was pinned to a certain nightly build, which was not available anymore.After regenerating the target files, the build of change 84214 succeeded. I used TPD's keyword "lazy" to avoid such a case in the future. If there are objections against the lazy resolution for the EMF Compare / EGit features, we can also turn it off for the integration update site and make sure that we never throw away old builds. But before releases someone has to regenerate the targets, which -- I assume -- will be done anyway before a release.I also took the liberty to rebase your change 83453 on top of mine to check if it succeeds. Unfortunately, it fails. But it at least this doesn't seem to be because the missing EMF Compare feature.Let me know if there is any other problem.Thanks and best wishes,Philip______________________________On Mon, Oct 31, 2016 at 10:57 AM, Philip Langer <planger@xxxxxxxxxxxxxxxxx> wrote:Hi again,I have a suspicion what went wrong with the build. In the release target platform, we don't use the tpd keyword "lazy" (or version 0.0.0 in the target), which means that when the target file has been generated, the version gets pinned to a specific one. However, as we use the nightly build, which will be overwritten each night, the pinned version is not available anymore.I'd suggest to use lazy (version 0.0.0 in the target) for the EMF Compare / EGit features, so that the actual version will be set when the target is resolved. Or are there objections against doing that in the release build?I'll be preparing a working patch soon: https://git.eclipse.org/r/#/c/84214/ Thanks and best wishes,PhilipOn Mon, Oct 31, 2016 at 9:54 AM, Philip Langer <planger@xxxxxxxxxxxxxxxxx> wrote:Hi Ernesto,thanks for the notice! I'll look at it and keep you posted. It is a bit surprising, because the missing feature should be available on every update site of EMF Compare (custom and official build). But I'll let you know as soon as I have looked at it in detail.Thanks and best wishes,PhilipOn Fri, Oct 28, 2016 at 9:06 PM, Ernesto Posse <eposse@xxxxxxxxxxxxx> wrote:______________________________Hello. We have builds failing complaining that they cannot findorg.eclipse.emf.compare.diagram.papyrus.feature.group/ 3.3.0. 201610160418[ERROR] Failed to resolve target definition /jobs/genie.papyrus-rt/Papyrus-RT-Gerrit-Releng/ workspace/source/org.eclipse. papyrusrt.targetplatform/ papyrusrelease/org.eclipse. papyrusrt.targetplatform.neon. releng/eclipse/org.eclipse. papyrusrt.targetplatform.neon. releng.target: Could not find "org.eclipse.emf.compare. diagram.papyrus.feature.group/ 3.3.0.201610160418" in the repositories of the current location -> [Help 1] org.apache.maven. MavenExecutionException: Failed to resolve target definition /jobs/genie.papyrus-rt/ Papyrus-RT-Gerrit-Releng/ workspace/source/org.eclipse. papyrusrt.targetplatform/ papyrusrelease/org.eclipse. papyrusrt.targetplatform.neon. releng/eclipse/org.eclipse. papyrusrt.targetplatform.neon. releng.target: Could not find "org.eclipse.emf.compare. diagram.papyrus.feature.group/ 3.3.0.201610160418" in the repositories of the current location What's the problem? Sounds like it's related to the recent changes with EMF Compare versions. Is there something that needs to be done in the target platforms and/or poms?--Ernesto PosseZeligsoft_________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt- dev --Dr. Philip Langer
Senior Software Architect / General Manager
EclipseSource Services GmbH_________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt- dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt- dev