Re: [papyrus-rt-dev] Version ranges in bundle dependencies

[MAGGI Benoit <Benoit.MAGGI@xxxxxx>]

Hi,

 

The patch looks good to me.

I will merge it this afternoon, if there is no objection.

 

Is there a wiki page for dev best practices on Meta-INF for Papyrus-rt project?

I think it would greatly improve the review to follow this convention:

The dependencies should follow this order:

-        Junit, guava (not eclipse stuff)

-        Org.eclispe.ui.*

-        Org.eclipse.emf.*

-        Org.eclipse.gmf.*

-        * (Other)

-        Org.eclipse.papyrus.infra.*

-        Org.eclipse.papyrus.uml.*

-        Ogr.eclipse.papayrus.rt.*

 

It helps a lot to detect any kind of strange dependency when reviewing on Gerrit.

 

Like any convention it’s as good as the team agree on/share it.

So any comments?

 

Regards,

Benoit

 

De : papyrus-rt-dev-bounces@xxxxxxxxxxx [mailto:papyrus-rt-dev-bounces@xxxxxxxxxxx] De la part de Philip Langer
Envoyé : jeudi 16 juin 2016 20:27
À : papyrus-rt developer discussions <papyrus-rt-dev@xxxxxxxxxxx>
Objet : Re: [papyrus-rt-dev] Version ranges in bundle dependencies

 

Hi,

 

I created bug 496266 and added the bundle version ranges of the plug-ins in tooling and the tests of tooling in https://git.eclipse.org/r/#/c/75421.

 

Thanks and best wishes,

 

Philip

 

On Thu, Jun 16, 2016 at 9:48 AM, SCHNEKENBURGER Remi 211865 <Remi.SCHNEKENBURGER@xxxxxx> wrote:

Hi Philip,

Thank you very much for this proposal, that would be nice if you could do the update for the other plugins in tooling also. No need to take into account onder versions, only the latest one would be sufficient.

Regards,
Rémi

---

De : Philip Langer
Envoyé : ‎16/‎06/‎2016 09:42
À : papyrus-rt developer discussions
Objet : Re: [papyrus-rt-dev] Version ranges in bundle dependencies

Hi,

 

thanks for your feedback! I'm happy to hear that you advocate this proposal.

 

I'll update the version ranges in the plug-ins I intend to add in the open Gerrit reviews accordingly. If you wish, I can also do the job for the remaining plug-ins in tooling. For the sake of simplicity, I'd take the current version as a min in the range, or is there a need to support older versions right now?

 

Thanks and best wishes,

 

Philip

 

--

Philip Langer

Senior Software Architect / General Manager
EclipseSource Services GmbH

_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev

 

--

Philip Langer

Senior Software Architect / General Manager
EclipseSource Services GmbH