Hi, Peter,
With the EOL clean-up there really is no choice but to do all files at once, because any single file that has EOL errors blocks all sorts of critical git operations.
It’s different with formatting. I don’t see much value in changing files that don’t need functionally meaningful changes just to update the formatting. But, that will be up to the committer team to decide. In any case, if you are concerned about what the save actions do, there is a remedy: everything done by the save action is implemented as an undoable operation. After hitting Cmd+S to save, just hit Cmd+Z to undo what the save actions did, reverting the file to just the changes that you intentionally made. So, for example, you could make some edits, hit Cmd+Shft+O to organize imports, Cmd+S to save, then Cmd+Z to revert to your edits with imports.
HTH,
Christian
On 17 March, 2016 at 04:46:59, Peter Cigéhn (peter.cigehn@xxxxxxxxx) wrote:
Hi,
If I may jump in, as a
beginner contributor, I would personally prefer a one-time update,
in the corresponding was as Christian did with the recent EOL
cleanup.
As a beginner contributor,
I prefer to change as little as possible in the contributions I
make, to feel more confident that I do not mess things up. I have a
feeling that if the automatic layout happens for more or less a
complete file (in the corresponding way as when you have EOL
issues), it might be harder for me (and the one doing the review)
to see/understand that I don't change more than needed.
But maybe this is an
exaggerated concern.
/Peter Cigéhn
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
|
