Hi,
Clean workspace is a little bit too much, since it will erase the entire Git repository. It will need to be cloned again
In theory, git clean + maven clean should be sufficient. If not, this certainly indicates an issue in the build process
Regards,
Camille
De : papyrus-rt-dev-bounces@xxxxxxxxxxx [mailto:papyrus-rt-dev-bounces@xxxxxxxxxxx]
De la part de Andrew Eidsness
Envoyé : mercredi 10 juin 2015 15:33
À : papyrus-rt-dev@xxxxxxxxxxx
Objet : Re: [papyrus-rt-dev] Gerrit build
I see that we don't have "Clean workspace" enabled. Do you think that this would be enough to get past this problem? If not, then how can we run this git command before the build? I don't see a place to add
pre-build steps.
-Andrew
On 15-06-10 09:27 AM, LETAVERNIER Camille wrote:
Hi,
Gerrit is quite sensitive to generated, git-ignored files, because they are not necessarily cleaned up after/before a build. Different Gerrit builds can thus interact with each other.
Using git clean –fdx (Or the equivalent option in Hudson/Git) typically solves this kind of issue. We had some issues with the Hudson option in Papyrus (It stopped working at some point), so we now use the git
clean –fdx command before running any Maven build
HTH,
Camille
I’m not able to understand the build failure on the Gerrit server:
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.21.0:compile (default-compile) on project org.eclipse.papyrusrt.codegen.statemachines.flat: Compilation failure: Compilation failure:
[ERROR] /jobs/genie.papyrus-rt/papyrusrt_gerrit_patch_triggered_build/workspace/codegen/org.eclipse.papyrusrt.codegen.statemachines.flat/src/main/generated-sources/xtend/org/eclipse/papyrusrt/codegen/statemachines/transformations/CppNamesUtil.java:[70]
[ERROR] case SmflatmodelPackage.ENTRY_ACTION:
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Duplicate case
[ERROR] /jobs/genie.papyrus-rt/papyrusrt_gerrit_patch_triggered_build/workspace/codegen/org.eclipse.papyrusrt.codegen.statemachines.flat/src/main/generated-sources/xtend/org/eclipse/papyrusrt/codegen/statemachines/transformations/CppNamesUtil.java:[79]
[ERROR] case CommonPackage.ACTION_CODE:
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Duplicate case
[ERROR] 2 problems (2 errors)
I’ve tried running maven locally and it completes without error.
CppNamesUtil.java is generated from CppNamesUtil.xtend. In my workspace and in my test maven build the generated .java file looks correct. Further, I don’t see any case statement around those lines. Could the Gerrit build be using a different version of
XTend?
-Andrew
On 15-06-10 08:26 AM, Andrew Eidsness wrote:
I've updated the Job to provide the right environment variables for make. The build now gets past that step.
However, it fails later on, in org.eclipse.papyrusrt.codegen.statemachines.flat. It looks like SmflatmodelPackage.ENTRY_ACTION and CommonPackage.ACTION_CODE cannot be found. Has the way that the .genmodels are generated changed?
-Andrew
On 15-06-10 08:19 AM, Andrew Eidsness wrote:
We need to provide two new environment variables when running the build. This should have been required for builds last night also -- I wasn't sure why the build was not failing. I guess that the Gerrit server
has been incorrectly bundling an old version of the RTS into the RTS feature.
I'll try to update the build for this.
Do you have advice on setting environment variables in Hudson? On Jenkins I used the EnvInject plugin, but that doesn't seem possible here. On Hudson I think that I have to add parameters to the Job and then set the default values appropriately.
-Andrew
On 15-06-10 07:57 AM, LETAVERNIER Camille wrote:
By the way, my second test commit [1] failed while it was supposed to work, but the error seems unrelated to the commit. I suspect the current master branch is broken
[1] 49899: [Gerrit Test] Clean build [I62cda32a]
https://git.eclipse.org/r/#/c/49899/
Camille
Hi Andrew,
We simply applied the standard Gerrit build configuration:
https://wiki.eclipse.org/Gerrit#Verifying_Changes_on_Hudson_using_Gerrit_Trigger_Plugin
The refspec and branch specifier didn’t match (Refspec was
refs/changes/*:refs/changes/* instead of $GERRIT_REFSPEC, and the branch was $GERRIT_REFSPEC
instead of **)
Additionally, we replaced the Git repository URI, from
git://git.eclipse.org/gitroot/papyrus-rt/org.eclipse.papyrus-rt.git
to /gitroot/papyrus-rt/org.eclipse.papyrus-rt.git, which is semantically identical but bypasses the Git server (The filesystem is accessed directly). That’s a recommendation from Eclipse to reduce the load on the git server,
but that’s minor.
Regards,
Camille
Good. I'm a bit curious about it though, could you summarize the problem and solution?
-Andrew
On 15-06-10 05:18 AM, LETAVERNIER Camille wrote:
Hi all,
The Gerrit build is now fixed and pulls the proper commit. Enjoy :)
Hi Andrew,
I’ve checked with Rémi, and it is not just a display issue. The Gerrit workspace still represents the state of commit 120dd53, so I think there’s something wrong with the branch configuration (Maybe the Gerrit
branch is fetched but not checked out)
I’ve noticed some differences with the Papyrus build configuration, so we’ll have a deeper look at this today
Regards,
Camille
Ernesto and I have been wondering about that as well. This shows up (incorrectly) in the "Changes" section on the Hudson build info page. As you mention the builds seem to work properly, however it would be
nice to fix anyhow.
The change that it has picked doesn't seem to be special in anyway. I'm guessing it was just the current tip when Ernesto created this build. However, I don't see it listed anywhere in the build configuration. Do you know where Hudson gets that information
from?
-Andrew
On 15-06-09 07:21 AM, LETAVERNIER Camille wrote:
Hi all,
I’ve pushed two contributions to the Papyrus-RT Gerrit server. This properly starts a build, but I wonder if it properly configured:
Last Built Revision: Revision 120dd53dda9c27586c516f36e8452cfb7bb791c5 (refs/changes/46/49746/1)
Checkout:workspace / /home/hudson/genie.papyrus-rt/.hudson/jobs/papyrusrt_gerrit_patch_triggered_build/workspace -
hudson.remoting.LocalChannel@35cd27f3
Fetching changes from the remote Git repository
Fetching upstream changes from git://git.eclipse.org/gitroot/papyrus-rt/org.eclipse.papyrus-rt.git
Commencing build of Revision 120dd53dda9c27586c516f36e8452cfb7bb791c5 (refs/changes/55/49755/1)
Commit 120dd53 is 3 weeks old. Also, when I look at the Gerrit build history (“Recent changes”), it seems that all Gerrit builds pick the same commit:
https://hudson.eclipse.org/papyrus-rt/job/papyrusrt_gerrit_patch_triggered_build/changes
Did I miss anything, or should the Gerrit Job configuration be fixed?
Regards,
Camille
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
|
