Re: [openmq-dev] PR 890 - Remove unused local ht

[Piotr Żygieło <piotr@xxxxxxxxxx>]

On Sun, 28 Feb 2021 at 22:28, arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
> but from the looks of it it's doing a NOOP, so it seems safe to remove.

Thanks for checking, Arjan.

It seems this piece was slightly reworked since
https://github.com/javaee/openmq-mq4/blob/master/mq/src/share/java/com/sun/messaging/jmq/jmsserver/core/PacketReference.java#L1533-L1542.
However - for me it looks unused there already.

I can't think of any side-effects that it could depend on but one:
NPEx on `ht.put(key=null, X)` (as headers (HashMap) can store null
key). But it's hard to believe in such intentions...

-- 
Piotrek