Re: [mdt-papyrus.dev] CQ: questions to respond

[Gabriel Merin Cubero <gmerin@xxxxxxxxxxxxx>]

Hi all,
I paste the answer that I have just sent:

Since we have contributed Activity and Sequence diagrams, I'll try to answer the mentioned questions with regard to our work:

Question 1 (Activity classes with dual contributors)
- Both Javier Cano and Marc Gil were directly involved in the development of the classes mentioned before. However, we accept your suggestion and, if more people make minor changes, we will just add the "and others" string.

Question 2 (SimpleStringErrorReporter)
- We are not involved in the development of that class.

Question 3 (JavaCC)
- We have not used JavaCC for generating purposes but we have re-used already existing classes whose authors did use JavaCC to create them. So, as for us, we are just using code generated by JavaCC, not distributing it.

Question 4 (FilteredCollectionView)
- We are not involved either in the development of this class.

Question 5 (Icons)
- All the icons that we have used come either from Eclipse, GMF, Topcased (only one icon) and handmade by ourselves.

I hope this helps.
Regards,
Gabriel Merin.



El lun, 02-02-2009 a las 14:21 +0100, TESSIER Patrick 202707 escribió:
> Hi,
> We have received comments from the CQ.
> I have paste the comment from the CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2858
> Each partners could repond to these questions:
>     1. The first point is for the activity diagram, Gabriel can you respond and do correction on the eclipse SVN
>     2. the second remarks is for us, we will modify it and repond to the CQ for this point.
>     3. I don't know who use JavaCC, partners that use it can you repond to this remarks.
>     4. This point is for Cédric, can you solve this problem?
>     5. for 5th point, each partners can verify if icon are originated from
>     Eclipse or are authored by the committers?
> Thanks for your helps,
> Best regards,
> Patrick
>  
> Hi Sebastien:
>
> I've completed the initial review and have some questions which I will need
> your help with:
>
> 1.  I believe you are reusing some files that exist in Eclipse.  It appears the
> following files have received dual copyright notices.  In situations where
> existing Eclipse files are being re-used and modified, the words "and others"
> are used to avoid having to list every copyright owner and because often, most
> of the content in the file was contributed by the initial copyright owner with
> subsequent modifications by others being smaller. 
>
> We would typically see the appending of "and others" on the copyright line with
> the Contributor Section updated as you have done only.  
>
> You may wish to refer to our template -
> http://www.eclipse.org/legal/copyrightandlicensenotice.php.
>
> AcceptEventActionCreateCommand.java
> AcceptEventActionItemSemanticEditPolicy.java
> ActivityFinalNodeCreateCommand.java
> ActivityItemSemanticEditPolicy.java
> ActivityPartitionActivityPartitionCompartment2CanonicalEditPolicy.java
> ActivityPartitionActivityPartitionCompartment2ItemSemanticEditPolicy.java
> ActivityPartitionActivityPartitionCompartmentCanonicalEditPolicy.java
> ActivityPartitionActivityPartitionCompartmentItemSemanticEditPolicy.java
> ActivitySubverticesCanonicalEditPolicy.java
> CallBehaviorActionCreateCommand.java
> CallOperationActionCreateCommand.java
> ControlFlowCreateCommand.java
> CreateObjectActionCreateCommand.java
> DataStoreNodeCreateCommand.java
> DecisionNodeCreateCommand.java
> ElementInitializers.java
> FlowFinalNodeCreateCommand.java
> ForkNodeCreateCommand.java
> InitialNodeCreateCommand.java
> JoinNodeCreateCommand.java
> MergeNodeCreateCommand.java
> OpaqueAction2CreateCommand.java
> OpaqueActionCreateCommand.java
> OpaqueActionItemSemanticEditPolicy.java
> PinCreateCommand.java
> SendObjectActionCreateCommand.java
> SendSignalActionCreateCommand.java
> SendSignalActionItemSemanticEditPolicy.java
> UMLDiagramUpdater.java
> UMLVisualIDRegistry.java
> UMLAbstractParser.java
>
> You may wish to modify...
>
> 2.  SimpleStringErrorReporter.java contains the following comment, "* Simple
> implementation of the error reporter for lexer/parser generated from ANTLR
> grammar".  Can you help elaborate on this use of ANTLR?  Are you distributing
> ANTLR?
>
> 3.  There is evidence of generated content from JavaCC in the contribution. 
> Can you confirm you are not distributing the JavaCC Tool just the generated
> content?
>
> 4.  FilteredCollectionView.java does not appear to be an EPL file.  It is
> matching to a third party file originating from MOBject.  In order to help you
> investigate this issue, lines 98-120 refer in your file?  
>
> 5.  The content contains >280 icons.  Can you confirm these originated from
> Eclipse or were authored by the committers?
>
> Thanks for your assistance,
> Sharon
>      
>     ---------------------------------------------------------
>     Patrick Tessier
>     Research Engineer
>     DRT LIST/DTSI/SOL/LISE CEA-Saclay
>     91191 Gif sur Yvette Cedex
>     Tel: 01 69 08 48 63
>     www.papyrusuml.org
>     ---------------------------------------------------------
>      
> _______________________________________________
> mdt-papyrus.dev mailing list
> mdt-papyrus.dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev

Gabriel Merin Analista/Modelador gmerin@xxxxxxxxxxxxx

Tel 96 371 6852 - Fax 96 337 8533