[mdt-papyrus.dev] CQ: questions to respond

["TESSIER Patrick 202707" <Patrick.TESSIER@xxxxxx>]

Hi,

We have received comments from the CQ.

I have paste the comment from the CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2858

Each partners could repond to these questions:

    1. The first point is for the activity diagram, Gabriel can you respond and do correction on the eclipse SVN

    2. the second remarks is for us, we will modify it and repond to the CQ for this point.

    3. I don't know who use JavaCC, partners that use it can you repond to this remarks.

    4. This point is for Cédric, can you solve this problem?

    5. for 5th point, each partners can verify if icon are originated from
    Eclipse or are authored by the committers?

Thanks for your helps,

Best regards,

Patrick

Hi Sebastien:

I've completed the initial review and have some questions which I will need
your help with:

1.  I believe you are reusing some files that exist in Eclipse.  It appears the
following files have received dual copyright notices.  In situations where
existing Eclipse files are being re-used and modified, the words "and others"
are used to avoid having to list every copyright owner and because often, most
of the content in the file was contributed by the initial copyright owner with
subsequent modifications by others being smaller. 

We would typically see the appending of "and others" on the copyright line with
the Contributor Section updated as you have done only.  

You may wish to refer to our template -
http://www.eclipse.org/legal/copyrightandlicensenotice.php.

AcceptEventActionCreateCommand.java
AcceptEventActionItemSemanticEditPolicy.java
ActivityFinalNodeCreateCommand.java
ActivityItemSemanticEditPolicy.java
ActivityPartitionActivityPartitionCompartment2CanonicalEditPolicy.java
ActivityPartitionActivityPartitionCompartment2ItemSemanticEditPolicy.java
ActivityPartitionActivityPartitionCompartmentCanonicalEditPolicy.java
ActivityPartitionActivityPartitionCompartmentItemSemanticEditPolicy.java
ActivitySubverticesCanonicalEditPolicy.java
CallBehaviorActionCreateCommand.java
CallOperationActionCreateCommand.java
ControlFlowCreateCommand.java
CreateObjectActionCreateCommand.java
DataStoreNodeCreateCommand.java
DecisionNodeCreateCommand.java
ElementInitializers.java
FlowFinalNodeCreateCommand.java
ForkNodeCreateCommand.java
InitialNodeCreateCommand.java
JoinNodeCreateCommand.java
MergeNodeCreateCommand.java
OpaqueAction2CreateCommand.java
OpaqueActionCreateCommand.java
OpaqueActionItemSemanticEditPolicy.java
PinCreateCommand.java
SendObjectActionCreateCommand.java
SendSignalActionCreateCommand.java
SendSignalActionItemSemanticEditPolicy.java
UMLDiagramUpdater.java
UMLVisualIDRegistry.java
UMLAbstractParser.java

You may wish to modify...

2.  SimpleStringErrorReporter.java contains the following comment, "* Simple
implementation of the error reporter for lexer/parser generated from ANTLR
grammar".  Can you help elaborate on this use of ANTLR?  Are you distributing
ANTLR?

3.  There is evidence of generated content from JavaCC in the contribution. 
Can you confirm you are not distributing the JavaCC Tool just the generated
content?

4.  FilteredCollectionView.java does not appear to be an EPL file.  It is
matching to a third party file originating from MOBject.  In order to help you
investigate this issue, lines 98-120 refer in your file?  

5.  The content contains >280 icons.  Can you confirm these originated from
Eclipse or were authored by the committers?

Thanks for your assistance,
Sharon

 

---------------------------------------------------------

Patrick Tessier

Research Engineer

DRT LIST/DTSI/SOL/LISE CEA-Saclay

91191 Gif sur Yvette Cedex

Tel: 01 69 08 48 63

www.papyrusuml.org

---------------------------------------------------------

 

BEGIN:VCARD
VERSION:2.1
N:TESSIER;Patrick
FN:TESSIER Patrick 202707 (Patrick.TESSIER@xxxxxx)
ORG:;SOL/LLSP
TITLE:Ingénieur Chercheur
TEL;WORK;VOICE:(01) 69 08 48 63
ADR;WORK;ENCODING=QUOTED-PRINTABLE:;B=E2t. 451 Pce 9;CEA SACLAY=0D=0ADRT/DTSI;GIF/YVETTE CEDEX;;91191;FRANCE
LABEL;WORK;ENCODING=QUOTED-PRINTABLE:B=E2t. 451 Pce 9=0D=0ACEA SACLAY=0D=0ADRT/DTSI=0D=0AGIF/YVETTE CEDEX 91191=
=0D=0AFRANCE
EMAIL;PREF;INTERNET:Patrick.TESSIER@xxxxxx
REV:20071011T094630Z
END:VCARD