Axel,
Comments in-line below:
Not
sure I understand how this would impact the package lookup
strategy. Also, if the description at the beginning of that bug is
supposed to be a description of the as-is state, it may be off. It
describes a top-down lookup order, but actually given the context
package, the lookup order is inside-out.
I only wanted to remind that there was an issue concerning to
provide a different way to find packages. I didn't look for the
motivations of said bug through the newsgroup/forum... Anyway. Ed
already disposed the bug, so ... ;P
The good news are that the patch doesn't
change the present behaviour so I
think we are painless with it. Besides, it adds some useful
information/documentation concerning the delagating registry
(which I didn't
know, BTW). +1
Ok, committed, with the following change:
Two minor comments:
- What about to include any kind of test to demonstrate the
problem of looking
up packages using the global epackage registry as delegate ?
- What about if we avoid creating a delegating registry with the
global
epackage registry ?. If it really doesn't work let's teach users
to use in the
correct way. (testAliasPackageName and
testRegularPackageNameInContextWithAliasLookupEnabled tests).
I replaced the use of the delegating constructor by the default
constructor which is possible because the two tests don't depend
on the contents of the default registry.
Nice.
Regarding demonstrating the problems of using the
(not-really-)delegating registry, did you have in mind to write a
test that unsuccessfully looks for a package through a
"delegating" registry which is only contained in the delegate?
Yes, that sounds like a good test case which exposes the underlying
problem. If the implementation suddenly changed to successfully find
the package, we would probably take this problem/discussion up again
;)
Cheers,
Adolfo.
Thanks and best,
-- Axel
Regards,
Adolfo.
_______________________________________________
mdt-ocl.dev mailing list
mdt-ocl.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev
|
