Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4e-dev] LanguageClientImpl.workspaceFolders() never used?
  • From: Ruben Porras Campo <Ruben.PorrasCampo@xxxxxxxxxx>
  • Date: Wed, 8 Dec 2021 11:10:08 +0000
  • Accept-language: es-ES, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=avaloq.com; dmarc=pass action=none header.from=avaloq.com; dkim=pass header.d=avaloq.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4FhCg8/c2LjmQfBb/WIfqFgVweDc2XyMp5KPtjtfR70=; b=aUiW/84bcscyCorD3pNKD437b8QpExsQCXeYZzbiob88N6ke1hSs5V6hUHdARy0wGaur5RIdZScfWB+QuV3/pxrAf8e8iVfJxwT+S44cgyCeevqM48TVNfX+BAw4O33IdCjvasFDR3TPLizhqou+2yNyJv9eaU8i4Nzm7LWG0dcDZIsNu2uTUtRMru+5Omt+tX1wPHOhWZTwSBYQ7BHy87fMxH6fKRy44ia41XQu775ryaCx04KPhXiOoBQNqrCNOgXvyQyYJRaPs/j+5pKuFiZYx4Le//Ecq2iM4e6Sjc1MvPxZ/EOMKWcHxCc+vhbnhwELSVmMK86YlOtmfICwyw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hbcRn8qjB1+DmgrGXSQO/HxladkBTx66ody8296pAepjn915nwiMQjneH5GpNYYADclEoci8XtsSmnh/isXKnSFlQCPl3s8GWQJatCp8YY2cGyhfKJ4TTQA0KTJDyOhRt6w8PfugoJacdEeSC+IuChdvBZ9RdvqtBWWcRpiphXoRKafUvnxeGzABJRrmh/P7vsZdoOshA8r4RzbhVYyQI2JF6vi4y+Hng+gdq+7zCP4Na6BD/BcVOVowpHF+WXO1CtcqZ+7UkjN6aVVDUdiiMwMTH6o/bmF1HEALJ7uwVEgJxvcx8vTXadl8SgiemK2fFBlGlNMb+i+npNmJC5dssg==
  • Delivered-to: lsp4e-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/lsp4e-dev/>
  • List-help: <mailto:lsp4e-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdfrfNGfETcpv7lyR/2Ac4WyyEWmMgAConwAACb6A5A=
  • Thread-topic: [lsp4e-dev] LanguageClientImpl.workspaceFolders() never used?

Hi Mickael,

 

Thanks for the answer. I think I can manage to do the customization in the server, so I will investigate how to do that.

 

Besides that, it really looks odd that the code in LanguageClientImpl.workspaceFolders() and in LanguageServerWrapper.watchProjects() are identical, and if we take the spec, as you say, this is client code. Therefore I would expect that the code used in the class LanguageClientImpl and not some duplicated code in LanguageServerWrapper, even if, as you say, there is not much room for customization.

 

I could not figure out  know how to correct it (or if it should be corrected), but if you think it is worth removing the code duplication and you would give me some pointers I could submit a pull request.

 

Regards

Ruben Porras Campo

 

From: Mickael Istria <mistria@xxxxxxxxxx>
Sent: Tuesday, December 7, 2021 5:28 PM
To: lsp4e developer discussions <lsp4e-dev@xxxxxxxxxxx>
Cc: Ruben Porras Campo <Ruben.PorrasCampo@xxxxxxxxxx>
Subject: Re: [lsp4e-dev] LanguageClientImpl.workspaceFolders() never used?

 

[EXTERNAL]

 

Hi all,

 

Hi,

 

I would like to configure LSP4E to filter out some eclipse projects (not only the closed ones) and do not know how to make it work. Could anyone help me?

 

This use-case is currently not supported. The LSP spec kind of makes explicit what "workspaceFolders" are from a client POV, and the expected result leave small to no room for customization/filtering.

Sure we could make LSP4E capable of it, but that would add a lot of complexity.

So let's first talk about your problem before talking about a remedy ;) Why do you need filtering of workspace folders? Couldn't such filtering be implemented (in a more portable manner) on the server side?

 


Please consider the environment before printing this e-mail.


IMPORTANT: This e-mail and any attachments contain information which is for the sole attention and use of the intended recipient. If this e-mail has been sent to you in error, please advise the sender of the error or contact Avaloq, completely delete the message and do not forward it or inform any other person of its contents. WARNING: E-mails can involve substantial risks e.g. lack of confidentiality, potential manipulation of contents and/or sender's address, incorrect recipient (misdirection), viruses etc. Avaloq assumes no responsibility for any loss or damage resulting from the use of e-mails. It is recommended that you do not send any sensitive information by unsecured e-mail. As a matter of principle, Avaloq does not accept any orders sent by e-mail and is not obliged to act on or respond to the e-mail.

Back to the top