| [lsp4e-dev] LanguageClientImpl.workspaceFolders() never used? |
|
Hi all, I would like to configure LSP4E to filter out some eclipse projects (not only the closed ones) and do not know how to make it work. Could anyone help me?
I have seen that the class LanguageClientImpl can be overridden/reimplemented, and then a custom implementation can used the extension point
org.eclipse.lsp4e.languageServer (clientImpl property). That class has an interface
/** * The workspace/workspaceFolders request is sent from the server to the client * to fetch the current open list of workspace folders. * *
@return null in the response if only a single file is open in the tool, * an empty array if a workspace is open but no folders are configured, * the workspace folders otherwise. */
@JsonRequest("workspace/workspaceFolders")
default CompletableFuture<List<WorkspaceFolder>> workspaceFolders() {
throw
new UnsupportedOperationException(); } I expected that by creating my own implementation, I could filter the projects as desired, but from my observation that is not the case: the code is never called. Apparently
a similar code to the one in org.eclipse.lsp4e.LanguageClientImpl.workspaceFolders() is present as well in LanguageServerWrapper.watchProjects(), and that is the one that is called:
wsFolderEvent.getAdded().addAll(Arrays.stream(ResourcesPlugin.getWorkspace().getRoot().getProjects()).filter(IProject::isAccessible).map(LSPEclipseUtils::toWorkspaceFolder).collect(Collectors.toList())); and causes the Language Server to be aware of projects I would like to filter out. Should this code not call the client implementation provided by LanguageClientImpl (which is exactly the same) or any other custom implementation, instead of providing its own
hardcoded version? I have tried to understand by myself if it is by intention that LanguageClient#workspaceFolders() is not called or if it is a bug, but I could not figure it out. Assuming it
is a bug, I also tried to figure out how to change LanguageServerWrapper.watchProjects() to call the custom implementation, but it is not clear to me how one would achieve that, it looks like the LanguageClient has a reference to the wrapper, but not the other
way around. Would you have any idea how to solve my problems?
Please consider the environment before printing this e-mail. IMPORTANT: This e-mail and any attachments contain information which is for the sole attention and use of the intended recipient. If this e-mail has been sent to you in error, please advise the sender of the error or contact Avaloq, completely delete the message and do not forward it or inform any other person of its contents. WARNING: E-mails can involve substantial risks e.g. lack of confidentiality, potential manipulation of contents and/or sender's address, incorrect recipient (misdirection), viruses etc. Avaloq assumes no responsibility for any loss or damage resulting from the use of e-mails. It is recommended that you do not send any sensitive information by unsecured e-mail. As a matter of principle, Avaloq does not accept any orders sent by e-mail and is not obliged to act on or respond to the e-mail. |
