Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4e-dev] LanguageClientImpl not API? 
> is LanguageClientImpl really not API (in which case, how does that square with it being the class we are required to derive from to implement this extension point)?

I guess LanguageClientImpl is not API because it's in the org.eclipse.lsp4e package, which is marked as x-internal=true in the org.eclipse.lsp4e plugin's MANIFEST.MF file [1].

I don't understand the motivation, though, for not making this class API. I checked the source code of an existing downstream plugin, Corrosion, and they use @SuppressWarnings("restriction") when implementing LanguageClientImpl [2]. Why make downstream plugins do that?

Thanks,
Nate 

[1] https://git.eclipse.org/c/lsp4e/lsp4e.git/tree/org.eclipse.lsp4e/META-INF/MANIFEST.MF?id=0b3e63afe266b30ad9de6d97e92fb9b70d84e0ea#n47
[2] https://github.com/eclipse/corrosion/blob/89fe281985940115be3d9c826d2a82832e22c9c1/org.eclipse.corrosion/src/org/eclipse/corrosion/edit/RLSClientImplementation.java#L23

Back to the top