Re: [lsp4e-dev] Requesting feedback to a change that adds support for ne

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E

From: Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>
Date: Mon, 14 May 2018 10:54:44 +0200
Delivered-to: lsp4e-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/lsp4e-dev>
List-help: <mailto:lsp4e-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=unsubscribe>

On May 11, 2018, at 14:26, Mickael Istria <mistria@xxxxxxxxxx> wrote:
I don't think it's worth making it configurable until we have a use-case for it.

Sorry, I must have misunderstood the discussion then. I thought there are concerns changing the current behavior because of existing implementations. But there is also a requirement to support a different behavior for a specific LS. Isn't that a use-case already?

Maybe the LSP should provide a `workspace/canHandleFile` request ?

I'm not sure why the protocol needs an extension. The concept of projects and sub-projects is pretty specific to Eclipse. IMO It doesn't make sense to have any LS deal with such abstractions/complexity. An LS should be pretty generic. Instead, the bridge between the LS and Eclipse needs to provide the correct adaption between Eclipse and the LS.

-Gunnar

--
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/

Follow-Ups:
- Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Mickael Istria

References:
- [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Ofterdinger, Markus
- Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Mickael Istria
- Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Ofterdinger, Markus
- Re: [lsp4e-dev] [CAUTION] Re: Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Pohl, Christoph
- Re: [lsp4e-dev] [CAUTION] Re: Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Gunnar Wagenknecht
- Re: [lsp4e-dev] [CAUTION] Re: Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Ofterdinger, Markus
- Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
  - From: Mickael Istria

Prev by Date: Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
Next by Date: Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
Previous by thread: Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
Next by thread: Re: [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E
Index(es):
- Date
- Thread

Breadcrumbs