| [lsp4e-dev] Requesting feedback to a change that adds support for nested sub-projects to LSP4E |
|
Hi, I’m currently working on a change to address the following issue in LSP4E:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=534322 With current version of LSP4E I'm facing an issue with duplicate LSP instances for the same file, if the file is part of a nested sub-project. For example: In my eclipse workspace I have project “A” that contains a nested project “B”. So the workspace looks like this: WorkspaceRoot project A project B sourceFile project B sourceFile If I open the "sourceFile" from each project, I get two instances of the LSP, because of the different projects it belongs to. This leads to strange behavior in the editor, e.g. the code completions
shows duplicate items, because of the two LSPs providing completion data. I prepared an initial change to modify this behavior and use the same language server instance for the parent- and sub-project:
https://git.eclipse.org/r/#/c/122109/ I kindly ask all interested language server providers to test their servers against this change to check if it breaks existing implementations and scenarios. As I mentioned this is a first try
to fix this problem and there could be a nicer solution out there. So, code contributions are also welcome
☺. Please provide feedback on the change, e.g. give a vote or contribute code. Thanks in advance for your support and feedback. Regards, Markus |