[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jsp-dev] [External] : Removing restrictions on direct commits
|
On 02/11/2021 16:11, Ed Bratt wrote:
Mark
What do you think about immediate commits (i.e. submit a PR then
immediately commit it -- or -- commit changes directly without PRs)?
I'm okay with whatever you want, just so long as it's clearly
articulated for the committer members.
I have no objection to either - although I don't see the point of PR
then immediate commit when you can commit directly without a PR. But if
that is what a committer prefers then I'd have no objection.
Mark
-- Ed
On 11/2/2021 9:06 AM, Mark Thomas wrote:
All,
In approx 24 hours time I intend to request that the branch
restrictions that prevent committers committing directly to the master
branch and those that require every PR to be reviewed before merge are
removed.
My reasoning is as follows:
- I have seen the benefits of these restrictions not being present in EL
- I'm expecting a number of non-substantive changes will be required to
successfully complete the release process and PR + review for all of
them will significantly slow us down
- Committers are perfectly capable of determining which changes need a
PR and review and which can be made directly - and if they get it
wrong changes can easily be reverted
I was intending to propose this change after the Jakarta 10 release
but on reflection, I think the sooner, the better.
Thoughts? Comments? Objects?
Mark
_______________________________________________
jsp-dev mailing list
jsp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsp-dev__;!!ACWV5N9M2RV99hQ!a_B3kTEVsblMqzdatmT4DjJTyOvtRZ8I8aeFy1i4-dMdTHWRhS5gkZZjzOy7J4I$
