Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsp-dev] [External] : Removing restrictions on direct commits
  • From: Ed Bratt <ed.bratt@xxxxxxxxxx>
  • Date: Tue, 2 Nov 2021 09:11:18 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+/qzTAYtK/JuTnylJxnDIXXDmrjMNfKt7izpwxKyKIo=; b=HMu+Ht+JTzCgNmQJdcv6yjz3F1gIR0xaB3Sky9/WW1ESRtGXtQPWhluy+3qVUaWTcAJ3fBdTU5HbJn6flyfVBQFYpp66C8fdM+ZxNNUGE0Qn9o8B2J80QJmQbDMBIkW39Fo+YnYUir24HSzVU4GcmkeUoYS1zCpz4k3o+g86JinRwbCuDoOkB2WaISc/iTueO/9dTWkoARELmhUI5NLjobTnt/aDC+3MKyBYnu7YczxQCMkdyNk2wp4KkFFhbISx8B+5G8F6rMbj2GQ7CJ/26EhQFLhmUUZzrHuYJ8yJ/nNTmqJWvb3+938gaYsAKzz4IOAM4hYr+7kmLXzND75bRA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ccLqvBVOtXy+MpJ5+IBSWy+FH0l/37dDafnkiiLblpbf0yE0XEgpBBJDin1z4W0c07CixX0FD6sV8UjxBsiWFShLCFOUlyh0XJToB8rSK2+uKl9SFZIM8BB7kFCHmd6SixGZR/ttM1CBpd7AzcZvJFZeJI+Tjw/ttgAqe8PH88qzkrsRRmBVBSrIxE3xEh9TuQgy4t/RzgVvbtZVEy5s82JnIpwzsuZPsG43zWdUHNteqXW646bDWnZFoN2l+/GPrPNQ3YgS3hRyFWddF7qd74uYROHex7UhSophRzuMH+JoijX3Zb4jybi1oqEjPowhnEhnYSbNZrobqw7Y3ttdNA==
  • Delivered-to: jsp-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/jsp-dev/>
  • List-help: <mailto:jsp-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/jsp-dev>, <mailto:jsp-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/jsp-dev>, <mailto:jsp-dev-request@eclipse.org?subject=unsubscribe>
  • User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1
Mark
What do you think about immediate commits (i.e. submit a PR then immediately commit it -- or -- commit changes directly without PRs)?
I'm okay with whatever you want, just so long as it's clearly articulated for the committer members. 

-- Ed

On 11/2/2021 9:06 AM, Mark Thomas wrote:

All,
In approx 24 hours time I intend to request that the branch restrictions that prevent committers committing directly to the master branch and those that require every PR to be reviewed before merge are removed. 

My reasoning is as follows:
- I have seen the benefits of these restrictions not being present in EL
- I'm expecting a number of non-substantive changes will be required to
  successfully complete the release process and PR + review for all of
  them will significantly slow us down
- Committers are perfectly capable of determining which changes need a
  PR and review and which can be made directly - and if they get it
  wrong changes can easily be reverted
I was intending to propose this change after the Jakarta 10 release but on reflection, I think the sooner, the better. 

Thoughts? Comments? Objects?

Mark


_______________________________________________
jsp-dev mailing list
jsp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsp-dev__;!!ACWV5N9M2RV99hQ!a_B3kTEVsblMqzdatmT4DjJTyOvtRZ8I8aeFy1i4-dMdTHWRhS5gkZZjzOy7J4I$

Back to the top