Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-ui-dev] Question concerning the reconciler

>From my understanding this would mean than:

- for the shared AST used in Editor this might be an improvement since it
lives longer
- in refactorings 99% of the AST have a very short life. We create them,
traverse them and forget them. Only the AST containing the element to be
refactored are kept in
  memory during the lifetime of the refactoring. For example inline method
keep the AST containing the method to be inline in memory as long as the
refactoring lives.
  The ASTs for the invocations however only have a short lifetime and only
one is in memory at a given point in time. So refactoring might not profit
from it.

Dirk


                                                                           
             Olivier Thomann                                               
             <Olivier_Thomann@                                             
             ca.ibm.com>                                                To 
             Sent by:                  "Eclipse JDT UI developers list."   
             jdt-ui-dev-bounce         <jdt-ui-dev@xxxxxxxxxxx>            
             s@xxxxxxxxxxx                                              cc 
                                                                           
                                                                   Subject 
             11.04.2005 18:07          Re: [jdt-ui-dev] Question           
                                       concerning the reconciler           
                                                                           
             Please respond to                                             
              "Eclipse JDT UI                                              
             developers list."                                             
             <jdt-ui-dev@eclip                                             
                  se.org>                                                  
                                                                           
                                                                           





My concerns are relative to
https://bugs.eclipse.org/bugs/show_bug.cgi?id=89281.

If this dom/ast tree is kept around for a while, it might be worthwhile to
fully initialize requested units in order to be able to clean them up. The
biggest issue is that doing this can penalized the creation of the tree. It
is a trade-off between memory and speed.

Let me know if you have any opinion on that. I'll try to create performance
tests for this PR. The problem is that simply doing a test once the tree is
created might appear as a regression whereas using the tree in the UI might
appear as an improvement.

Olivier_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev




Back to the top