Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-ui-dev] Question regarding NamePatternFilter



When we created the internal filter class we assumed it is used for JDT
views which show Java elements and resources. However since the
CustomFiltersActionGroup is public API we should also adapt to
IJavaElement..

Dani


                                                                           
             "Jesper Kamstrup                                              
             Linnet"                                                       
             <eclipse@kamstrup                                          To 
             -linnet.dk>               <jdt-ui-dev@xxxxxxxxxxx>            
             Sent by:                                                   cc 
             jdt-ui-dev-admin@                                             
             eclipse.org                                           Subject 
                                       Re: [jdt-ui-dev] Question regarding 
                                       NamePatternFilter                   
             14.04.2003 11:17                                              
                                                                           
                                                                           
             Please respond to                                             
             jdt-ui-dev@eclips                                             
                   e.org                                                   
                                                                           
                                                                           




I'm currently working on a callers/callees view. This view presents a tree
containing IMember instances. Each IMember instance may exist in multiple
locations in the tree (e.g. in case of recursive calls). In order to
implement getParent(Object) in the content provider I need to associate the
actual parent with each occurrence of an IMember instance. For this reason
I
need to wrap the IJavaElement's in another class.

I can change the view's selection provider to return the IMember instances
instead of the wrapper object so that's not a problem. Other classes that
interact with the content provider such as ViewerFilter's will, however,
have problems if they don't adapt to the actual element.

I have filed a bug report:
http://bugs.eclipse.org/bugs/show_bug.cgi?id=36427

Please let me know if I'm completely wrong (also if I'm just slightly wrong
:-).

Regards,

Jesper


-----Oprindelig meddelelse-----
Fra: jdt-ui-dev-admin@xxxxxxxxxxx
[mailto:jdt-ui-dev-admin@xxxxxxxxxxx]Pa vegne af Daniel Megert
Sendt: 14. april 2003 10:56
Til: jdt-ui-dev@xxxxxxxxxxx
Emne: Re: [jdt-ui-dev] Question regarding NamePatternFilter







We adapt to IResource because most likely there will be such an adapter. Do
you have a real use case which is not covered?

Dani



             "Jesper Kamstrup
             Linnet"
             <eclipse@kamstrup                                          To
             -linnet.dk>               <jdt-ui-dev@xxxxxxxxxxx>
             Sent by:                                                   cc
             jdt-ui-dev-admin@
             eclipse.org                                           Subject
                                       [jdt-ui-dev] Question regarding
                                       NamePatternFilter
             11.04.2003 15:30


             Please respond to
             jdt-ui-dev@eclips
                   e.org






Hi,

In org.eclipse.jdt.internal.ui.filters.NamePatternFilter, the select method
checks whether the element is an instance of IJavaElement. If not, it
attempts to obtain an adapter to an IResource. Is there any reason why it
doesn't try to adapt to IJavaElement as well?

Best regards,

Jesper

------------------------------------
Jesper Kamstrup Linnet
Peter Bangs Vej 91, 1.tv.
2000 Frederiksberg

Tlf. 38 74 80 94 / 26 24 80 94



_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-ui-dev


_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-ui-dev



_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-ui-dev




Back to the top