Re: [jakartaee-tck-dev] [External] : Re: Official Annotations 3.0.0 TCK?

[Arjan Tijms <arjan.tijms@xxxxxxxxxxx>]

Hi

I did look at the Common Annotations TCK, and it’s basically only a signature test:
https://github.com/jakartaee/common-annotations-api/blob/master/tck/pom.xml

Though I have to say that this test class doesn’t look universal to me:

https://github.com/jakartaee/common-annotations-api/blob/master/tck/src/main/java/ee/jakarta/tck/annotations/signaturetest/CAJSigTestIT.java

Would it not be easier if the runner pom just: 

1. Downloaded the GlassFish distribution used for testing

2. Defined a property to point to the commons API jar file within the just downloaded GlassFish

3. Run the Signature test plugin with the previously generated sig file and the just defined property as input?

Maybe also clearer to the generation of the signature is a separate module, so that's clear this is not part of the TCK test, but something the project maintainers only do once? For that the project could perhaps just copy this one and adjust for the CA coordinates: https://github.com/jakartaee/faces/blob/4.1/tck/faces-signaturegen/pom.xml

Kind regards,

Arjan Tijms

On Mon, 11 Mar 2024 at 17:32, Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:

Hi,

Thanks everyone for the answers!

Kind regards,

Arjan Tijms

On Mon, 11 Mar 2024 at 17:07, Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

+Lukas

 

More userguide changes were made after the TCK was migrated to https://github.com/jakartaee/common-annotations-api/tree/master/tck .

 

Any further changes can be made to the TCK in the above specification project based on the review.

 

We will be removing the annotations TCK sources from https://github.com/jakartaee/platform-tck/tree/tckrefactor soon.

 

Regards,
Alwin

 

From: Scott Marlow <smarlow@xxxxxxxxxx>
Date: Monday, 11 March 2024 at 9:15 PM
To: Arjan Tijms <arjan.tijms@xxxxxxxxxxx>
Cc: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>, Alwin Joseph <alwin.joseph@xxxxxxxxxx>, Gurunandan Rao <gurunandan.rao@xxxxxxxxxx>, Edward Burns <Edward.Burns@xxxxxxxxxxxxx>, Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx>
Subject: [External] : Re: Official Annotations 3.0.0 TCK?

 

 

 

On Mon, Mar 11, 2024 at 10:28 AM Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:

Hi, 

 

Just wondering, is https://ci.eclipse.org/jakartaee-tck/job/11/job/standalone-tck/job/eftl-annotations-standalonetck-build/ the official TCK to ratify Jakarta Annotations 3.0.0 for Jakarta EE 11?

 

Is it fully done?

 

No, the documentation needs changes which is mentioned in https://github.com/jakartaee/platform-tck/pull/1222

 

 

Kind regards,

Arjan Tijms