Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] [ejb-dev] Question about removing failing EJB legacy compatibility tests in Jakarta EE 9 Platform TCK 


On 9/9/20 10:40 AM, Lance Andersen wrote:
The intent of the compatibility tests are exactly that compatibility with the older Java EE releases. They should either be supported as is or removed.
Agreed although we are also giving the EJB SPEC team the opportunity to consider if they would like to turn these failing tests into new (optional) BMP/CMP tests that use Jakarta EE 8+ schemas.
Given this is Jakarta EE and not Java EE then you should remove these unless you are supporting the Java EE XSDs.  They are not the same test otherwise.
As per https://jakarta.ee/specifications/platform/9/platform-spec-9-SNAPSHOT.html#a3447 we should remove these tests. Or we could change these tests into non-compat tests. 

Thanks,
Scott




HTH
Lance
On Sep 9, 2020, at 10:26 AM, Jean-Louis Monteiro <jlmonteiro@xxxxxxxxxxxxx <mailto:jlmonteiro@xxxxxxxxxxxxx>> wrote: 

Hi,
On top of my head, there is only Interop and JAX-RPC related features/tests pruned. 
Entity CMP/BMP are part of the optional spec (as opposed to required).

But one may still want to implement and therefore test it, isn't it?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro <https://urldefense.com/v3/__http://twitter.com/jlouismonteiro__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasZ6g_AtKg$> http://www.tomitribe.com <https://urldefense.com/v3/__http://www.tomitribe.com/__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7Masaw5togEw$>
On Tue, Sep 8, 2020 at 5:51 PM Scott Marlow <smarlow@xxxxxxxxxx <mailto:smarlow@xxxxxxxxxx>> wrote: 

    Hi,

    Does the EJB team have input to share on removing legacy EJB
    BMP/CMP compatibility tests that were written to test J2EE
    1.2/1.3/1.4?

    As part of the conversion to use Jakarta EE 9 XSDs  [1], we
    updated 1.2/1.3/1.4 BMP/CMP compatibility tests.  Now that we are
    seeing test failures [2].  We are wondering if we should instead
    remove failing tests [3][4][5].

    We updated these tests to use the Jakarta EE 9 XSDs because
    Jakarta EE 9 implementations are only required to support Jakarta
    EE 8+ schemas.

    Could the EJB team give a quick answer on this (by Sept 10)?  If
    more than a few days is needed, please do indicate so.

    Scott

    [1] https://github.com/eclipse-ee4j/jakartaee-tck/pull/474
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/pull/474__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasZyPXtVSQ$>
    [2]
    https://github.com/eclipse-ee4j/jakartaee-tck/pull/474#issuecomment-688278559
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/pull/474*issuecomment-688278559__;Iw!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasYk7sbjxg$>
    [3]
    https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/bmp/compat13_14/Client.java#L76
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/bmp/compat13_14/Client.java*L76__;Iw!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasYd1QDz4g$>
    [4]
    https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/bmp/compat12_13/Client.java#L78
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/bmp/compat12_13/Client.java*L78__;Iw!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasYRd_ZoPQ$>
    [5]
    https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/cmp11/compat12_14/Client.java
    <https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/ejb/ee/deploy/entity/cmp11/compat12_14/Client.java__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasauwLEoKg$>

    _______________________________________________
    ejb-dev mailing list
    ejb-dev@xxxxxxxxxxx <mailto:ejb-dev@xxxxxxxxxxx>
    To unsubscribe from this list, visit
    https://www.eclipse.org/mailman/listinfo/ejb-dev
    <https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ejb-dev__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7MasZM36kKAg$>

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!Lgv7cmsd7HS2ffs219Yk2h3Dyz2VY-1xPs0t8VoQq7aYckP5mkYzMn7Masan7JzG4w$ 


Best
Lance
------------------



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen@xxxxxxxxxx <mailto:Lance.Andersen@xxxxxxxxxx>





_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top