Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] EJB TCK PR pending
Yes, I understand and agree the tests aren't really what I expected.
We can indeed improve the coverage and the actual tests, but I'm with Lance (not that I'm lazy or I don't want to do it).

The goal of the PR was to make sure we had something to test the repeatable form of @Schedule.

I can open a ticket either on Enterprise Beans repo of TCK repo to make sure we improve the @Schedule tests overall afterwards.

Is that fine with you?




On Tue, Sep 1, 2020 at 8:24 PM Lance Andersen <LANCE.ANDERSEN@xxxxxxxxxx> wrote:
The fix in question looks ok.  I would suggest only fixing show stoppers for Jakarta EE 9 and not include the change in the release

On Sep 1, 2020, at 12:54 PM, Scott Marlow <smarlow@xxxxxxxxxx> wrote:



On 9/1/20 9:51 AM, Jean-Louis Monteiro wrote:
Hi all,
Can someone have a quick look at the pending PR for Enterprise Beans?
https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jakartaee-tck/pull/452__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF5n5bDvCQ$ It's really really small and easy to review. There is almost nothing inside.
As the last runs were close to 100% complete on Jakarta Enterprise Beans, I'd like to make sure we are ready to build and promote so we can create a certification request.

Pasting my feedback from the pr in case others have input to share here:

>The test change looks good to me as it seems to not require testing >anything new other than requiring that the EJB container support >repeatable Schedule.

>My concern though is about improving this test while we are in the >middle of trying to get through the SPEC API Ballots for Jakarta EE 9.

>I also wonder if adding additional test coverage now is fair to >GlassFish 6.0, which is trying to reach zero failures. Maybe GlassFish >6.0 would pass with this change but it just feels late to make an >unrequired change while we are focusing still on making other required >changes (e.g. like switching to only Jakarta 8+ XSDs).

Other thoughts?

Scott
Thanks
--
Jean-Louis Monteiro
https://urldefense.com/v3/__http://twitter.com/jlouismonteiro__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF45zXGKEA$ https://urldefense.com/v3/__http://www.tomitribe.com__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF7vw3ud6w$  <https://urldefense.com/v3/__http://www.tomitribe.com/__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF6oiRNUdQ$ >
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF5t-aYjjQ$

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!JUnpAc5Sybxa8NRE0sHK2n--f43A9NYXzCaFYiqIe7tPe0m-89byeNkmiF5t-aYjjQ$


Best
Lance
------------------



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen@xxxxxxxxxx




Back to the top