Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] EJB TCK PR pending



On 9/1/20 9:51 AM, Jean-Louis Monteiro wrote:
Hi all,

Can someone have a quick look at the pending PR for Enterprise Beans?
https://github.com/eclipse-ee4j/jakartaee-tck/pull/452

It's really really small and easy to review. There is almost nothing inside.
As the last runs were close to 100% complete on Jakarta Enterprise Beans, I'd like to make sure we are ready to build and promote so we can create a certification request.

Pasting my feedback from the pr in case others have input to share here:

>The test change looks good to me as it seems to not require testing >anything new other than requiring that the EJB container support >repeatable Schedule.

>My concern though is about improving this test while we are in the >middle of trying to get through the SPEC API Ballots for Jakarta EE 9.

>I also wonder if adding additional test coverage now is fair to >GlassFish 6.0, which is trying to reach zero failures. Maybe GlassFish >6.0 would pass with this change but it just feels late to make an >unrequired change while we are focusing still on making other required >changes (e.g. like switching to only Jakarta 8+ XSDs).

Other thoughts?

Scott

Thanks

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com <http://www.tomitribe.com/>

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev




Back to the top