Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Next steps for updating the jakartaee-tck repo...
Thanks for the update Scott, 
I hadn't started yet the javax.ws. Happy to see that a new PR already covered it :).

I can move to cover a PR for javax.jms. the PR should be ready before the end of the week.

As a side note, I notice this is not the first time this happens. Don't get me wrong I'm not angry at all. But I wonder if we can enable the https://github.com/eclipse-ee4j/jakartaee-tck/projects in order to keep track of who is doing what?



On Thu, Apr 23, 2020 at 9:49 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:


On Mon, Apr 20, 2020 at 6:41 PM Cesar Hernandez <chernandez@xxxxxxxxxxxxx> wrote:
Thanks, Scott for the update.
I updated the PR with the feedback you provided.

I'll follow up on another PR with the copyright plugin. 
Is someone else working on javax.ws?? If not, I can volunteere on it.

Hi Cesar,

Have you started making your changes for javax.ws? yet?  If not, could you help with a different javax.* area?

The reason why I ask, is that https://github.com/eclipse-ee4j/jakartaee-tck/pull/220 just appeared, which duplicates the work that you mentioned doing.  The https://github.com/eclipse-ee4j/jakartaee-tck/pull/220 change is as tested, as it could be (passed 2666 tests and failed 142).

I am happy that the Platform TCK is getting help from you and others, which is excellent to see! 

If we review and merge https://github.com/eclipse-ee4j/jakartaee-tck/pull/220, that leaves the following to update:

ag --ignore .git  -l javax.| xargs sed -i 's/javax\.faces\./jakarta\.faces\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.jms\./jakarta\.jms\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.json\./jakarta\.json\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.auth\./jakarta\.security\.auth\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.enterprise\./jakarta\.security.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.jacc\./jakarta\.security\.jacc\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.websocket\./jakarta\.websocket\./g'

Scott

 

On Mon, Apr 20, 2020 at 1:22 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
Hi Cesar,

Thank you very much for volunteering to help out!  Your steps look correct to me, however, I should of mentioned one additional detail, that the signature files (e.g. *.se8) under src/com/sun/ts/tests/signaturetest/ need to be regenerated, not manually updated.  Sorry about that. :(

Your changes to  install/jakartaee/bin/sig-test-pkg-list_se9.txt +  install/jakartaee/bin/sig-test-pkg-list.txt look correct but I'm afraid that the other changes to actual signature files (*.se8) should be reverted.

I'll respond on the pr directly.  Olivier Lamy is already doing servlet and I just created a pr for switching javax.enterprise to jakarta.enterprise, available still are:

ag --ignore .git  -l javax.| xargs sed -i 's/javax\.faces\./jakarta\.faces\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.jms\./jakarta\.jms\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.json\./jakarta\.json\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.mail\./jakarta\.mail\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.persistence\./jakarta\.persistence\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.auth\./jakarta\.security\.auth\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.enterprise\./jakarta\.security.enterprise\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.security\.jacc\./jakarta\.security\.jacc\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.websocket\./jakarta\.websocket\./g'
ag --ignore .git  -l javax.| xargs sed -i 's/javax\.ws\.rs\./jakarta\.ws\.rs\./g'

Some of these have already been partially done.

Also, we have been updating the file Copyright date, to add 2020.  If there currently is one year listed in Copyright, then add ", 2020", otherwise update the second date listed to 2020.

I've been using the https://github.com/eclipse-ee4j/glassfish-copyright-plugin project for updating Copyright dates.  Build this project locally and then try the following before you (git) commit your changes (it will only update the Copyright date for modified files):

repo=~/.m2/repository/org/glassfish/copyright/glassfish-copyright-maven-plugin
v=`ls $repo | grep '^[1-9]' | tail -1`
for i in `git status  --porcelain --untracked-files=no | cut -d' ' -f3`; do java -cp $repo/$v/glassfish-copyright-maven-plugin-$v.jar org.glassfish.copyright.Copyright -r -c $i; done

If you have to modify the above for OSX, please consider creating a pr on https://github.com/eclipse-ee4j/glassfish-copyright-plugin to update the README.md to include OSX. :)

Thanks,
Scott


_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top