Re: [jakartaee-spec-project-leads] Are reviewers required to be committe

[Tom Jenkinson <tom.jenkinson@xxxxxxxxxx>]

Thanks for the response, Steve.

In this circumstance I have a PR that has been reviewed (and GitHub would allow the merge) but the reviewer is not a committer to the specific project and so I am questioning whether anything in the Jakarta development process requires the reviewer to be a committer to the specific project in order that a committer proceed to merge.

On Mon, 8 Jun 2020 at 10:29, Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

I think it depends on the rules set up on the GitHub repo. I think many are set up to require an approving review to merge to master.

 

From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 08 June 2020 10:24
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Subject: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?

 

Hi,

 

Please can I check, is it required that we obtain a review on a pull request from a person listed as a committer to a specific project in order to merge a change?

 

Many thanks,

Tom

_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads