Re: [jakartaee-spec-project-leads] Are reviewers required to be committe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?

From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
Date: Mon, 8 Jun 2020 09:28:59 +0000
Accept-language: en-GB, en-US
Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHDhgKh4k5OmQQftqxtGUDVJWiwTrGL1FOzbVBvNTZk=; b=OJzVAzhoiS4gAd4uWrfKhLu/ZYAAJX3yQDL9udY0Yw+du9pTYR4IfWUNGF2fV+ysQfB1BmtXQlB88gwMQZhJXK92wX32yhxLTCQwsOc0R4BNGjsy2CfVGM6ViVgHKrVmWSenKsv/+por0k+Q2IavmJtzWQepw5RqdsLadraHYr5T6+01bBV3YhEd1zbQ+IRQkn7kiB5aK2gVeZMHELdcYkmt30xWKyPGrpOpPFOQTxiHhdrayeAHI4eCjCPJSv3mJeHCIXhTdbBvZrX0WdRHEPh/rylJ9gFDUStk5WT/dzLijHxzuBR6xx/KInUCdtqU+MRoxDsx1/ZySVsLYTE3wQ==
Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JgWROmgrz58ACuD/hLvm8stSOYGzVCR7p58IoxuojYF+nsYH+ABOmUIg1t/QqLoyXv2d4xawdG39CCnvKdxcmFxK3dG0DXeJmEfYNY2R8o+Vme4TxsZ02MW7vxCxVMGO1ynpXHnHyidY7Yh0yKvdqTEZKYXTws8U1kcQ0xjHAlpE3+Z+5Ew3HlFJ+sveQ3fQN4MBGyRVEKJNv8xbcRm8WPxdSVpKQq8GyWq/HxnSEyuAFOSVSkcDkhO1dgfP4VLX6nKwqIk7y6lENBPgcuZe14rQhFmRtv9RNgnDAlhGqndgfoMdqlqPl7oGFdR3WPlAwt5bAhrZUE5HUxSmcltuKg==
Delivered-to: jakartaee-spec-project-leads@xxxxxxxxxxx
List-archive: <https://www.eclipse.org/mailman/private/jakartaee-spec-project-leads>
List-help: <mailto:jakartaee-spec-project-leads-request@eclipse.org?subject=help>
List-subscribe: <https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads>, <mailto:jakartaee-spec-project-leads-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://www.eclipse.org/mailman/options/jakartaee-spec-project-leads>, <mailto:jakartaee-spec-project-leads-request@eclipse.org?subject=unsubscribe>
Thread-index: AQHWPXamBhL30T9SXk+IAydyhqf5EajOc1iw
Thread-topic: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?

I think it depends on the rules set up on the GitHub repo. I think many are set up to require an approving review to merge to master.

From: jakartaee-spec-project-leads-bounces@xxxxxxxxxxx <jakartaee-spec-project-leads-bounces@xxxxxxxxxxx> On Behalf Of Tom Jenkinson
Sent: 08 June 2020 10:24
To: JakartaEE Spec Project Leadership discussions <jakartaee-spec-project-leads@xxxxxxxxxxx>
Subject: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?

Hi,

Please can I check, is it required that we obtain a review on a pull request from a person listed as a committer to a specific project in order to merge a change?

Many thanks,

Tom

Follow-Ups:
- Re: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
  - From: Tom Jenkinson

References:
- [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
  - From: Tom Jenkinson

Prev by Date: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
Next by Date: Re: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
Previous by thread: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
Next by thread: Re: [jakartaee-spec-project-leads] Are reviewers required to be committers to a specific project to allow merging?
Index(es):
- Date
- Thread

Breadcrumbs