Re: [jakartaee-platform-dev] module-info tests

[Scott Marlow <smarlow@xxxxxxxxxx>]

On 10/6/21 6:19 PM, Scott Stark wrote:

Theoretically that is true, but we are not requiring that JPMS be used in EE containers, so the signature tests would not validate that level of visibility. The other general issue is that one can always choose to not use modules, and so everything is visible.

Certainly for EE10 having public classes in an API jar that are meant to be internal will fail the signature tests.

    +1 as signature testing does not allow super-setting.

On Oct 6, 2021 at 4:06:27 PM, Thiago Henrique Hupner <thihup@xxxxxxxxx> wrote:

Another question would be:

Can an API module include public classes that are not exported? It shouldn't be considered part of the API, but I don't know exactly

how the rules apply to an implementation, if it only can use package-private/inner classes to implement the code or if it

can delegate a class in other package that is not part of the API.

But if it is in other package, the class needs to be public. In the JDK there is a lot of API classes that uses public classes in an internal package,

like the implementation of java.lang.module.ModuleDescriptor is in jdk.internal.module.ModuleInfo, and it is a public class.

_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev