Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-examples-dev] Pull Request Submitted
Hi,

Thanks Ed! 

There's a couple of options to consider. Most EE4J projects use Eclipse Jenkins, but there's GitHub actions too, and of course Travis is an option as well. All of them would need some of those settings changed so the Travis CI example specifically bug is quite handy.

The very similar in goals and setup Java EE samples uses travis as well. See e.g. https://travis-ci.org/github/javaee-samples/javaee7-samples

Kind regards,
Arjan



On Thu, Apr 30, 2020 at 1:21 AM Ed Bratt <ed.bratt@xxxxxxxxxx> wrote:

If committer teams want to change the repo. settings, the best option is to submit a web-admin request in Eclipse Bug Tracker. Here are a couple of example:

Add branch protection to Jakarta RESTful Web Services repository

https://bugs.eclipse.org/bugs/show_bug.cgi?id=534177

I don't know that you need to be quite as formal with a committer vote and the decisions, but they will implement whatever your team needs. (there is a screen-shot of the branch protection options in this issue)

Here is an example request for adding Travis CI

https://bugs.eclipse.org/bugs/show_bug.cgi?id=533020

-- Ed

On 4/29/2020 4:04 PM, arjan tijms wrote:
Hi,

On Thu, Apr 30, 2020 at 12:52 AM Jason Pollard <jpollard91@xxxxxxx> wrote:
I am curious what other hooks exist for PR's in this GitHub repo, like any type of CI/CD that runs for PR's (if even just running tests).

For the moment none, but as an Eclipse project a Jenkins instance can be requested, and it will then appear here: https://ci.eclipse.org That will add a hook for that, we don't need to add that ourselves.
All committers have access to the Jenkins instance.

Running tests is pretty much the main purpose of this project ;)
 
Does anyone have access to the repo settings?

Yes, Dmitry and Ivar have access among others. They are org (eclipse-ee4j) wide.

Kind regards,
Arjan Tijms





 


Maybe a next step is to elect/choose repo maintainer(s) so that we can get PR's approved and Manfred can relax on the beach now that he has retired 🙂

Cheers,
Jason Pollard

From: jakartaee-examples-dev-bounces@xxxxxxxxxxx <jakartaee-examples-dev-bounces@xxxxxxxxxxx> on behalf of omniprof@xxxxxxxxx <omniprof@xxxxxxxxx>
Sent: Wednesday, April 29, 2020 3:45 PM
To: jakartaee-examples-dev@xxxxxxxxxxx <jakartaee-examples-dev@xxxxxxxxxxx>
Subject: [jakartaee-examples-dev] Pull Request Submitted
 

Hi,

 

I have just submitted a pull request, my first ever, for jakartaee-examples. It consists of The Learning Servlet along with a minor error correction to the parent pom file. As requested it is in the same style as all other individual projects and does not use any external libraries. There is a simple test that deploys the web site and then clicks on a button to execute the servlet.

 

Feel free to make any suggestions or criticisms. I hope to submit more especially as I have figured out how to do it, finally.

 

Ken Fogel

 

_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

_______________________________________________
jakartaee-examples-dev mailing list
jakartaee-examples-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-examples-dev

Back to the top