Re: [jakartabatch-dev] whitespace / formatting

["Scott Kurz" <skurz@xxxxxxxxxx>]

Thanks Martijn for the idea.

So if I understand correctly,

1. This approach doesn't require you to use the Eclipse IDE
2. Your POM shows how to enforce consistent settings, but someone still has to decide what those settings' values are: (code formatting, etc.)

As long as we don't require Eclipse, I don't have too many preference on the format details, so I like the general idea.

------------------------------------------------------
Scott Kurz
WebSphere Batch and Developer Experience
skurz@xxxxxxxxxx
--------------------------------------------------------

Martijn Dashorst ---04/02/2020 08:12:40 AM---Sorry for the spam, The plugin requires a resource jar file to be installed (or downloaded from

From: Martijn Dashorst <martijn.dashorst@xxxxxxxxx>
To: jakartabatch developer discussions <jakartabatch-dev@xxxxxxxxxxx>
Date: 04/02/2020 08:12 AM
Subject: [EXTERNAL] Re: [jakartabatch-dev] whitespace / formatting
Sent by: jakartabatch-dev-bounces@xxxxxxxxxxx

---

Sorry for the spam,

The plugin requires a resource jar file to be installed (or downloaded from Maven central) with the particular settings.

This is de dependency defined on the plugin definition, and something you need to craft separately.

Martijn


On Thu, Apr 2, 2020 at 2:03 PM Martijn Dashorst <martijn.dashorst@xxxxxxxxx> wrote:

Here's a working POM section for what I described earlier:

https://gist.github.com/dashorst/b80f4a8a13fb945a41e5f7b2ffc7e31f

Martijn


On Wed, Apr 1, 2020 at 4:43 PM Martijn Dashorst <martijn.dashorst@xxxxxxxxx> wrote:
At $$$ company we have automatic enforcement of formatting by importing the company settings into Eclipse through a resource bundle. I think the scout project copied our approach and made a maven plugin just for this.

For a project that is open source, forcing eclipse might be a bridge too far (even though we're at the Eclipse Foundation).

That said, picking a standard that is implemented across the different IDE's and enforcing that through
- default settings that can be imported at the project level
- a checkstyle plugin
would be good.

While I don't have a love for the sun coding standards, I think those are widely supported across IDEs.

Martijn


On Tue, Mar 31, 2020 at 5:00 PM Scott Kurz <skurz@xxxxxxxxxx> wrote:
For each of the API/TCK projects, I don't think we ever paid too much attention to consistent formatting. I'd have to check what our EOL situation is as well.

If anyone wants to be the first to propose a format and possibly enforcement (e.g. checkstyle) be my guest.

Otherwise, I'm going to try to just reject PRs that mix reformatting with content changes.

Though for something like this:
https://github.com/thadumi/batch-tck/commit/c9b29b42d68eeb4c12cc264897079be926493737
I think I'd just break that into two commits: one removing trailing whitespace for all Java parts and then the content.

Tried to note this here: https://github.com/eclipse-ee4j/batch-api/wiki/Ways-To-Contribute

But if you're interested, please feel free to propose/implement.
------------------------------------------------------
Scott Kurz
WebSphere Batch and Developer Experience
skurz@xxxxxxxxxx
--------------------------------------------------------
_______________________________________________
jakartabatch-dev mailing list
jakartabatch-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartabatch-dev


--
Become a Wicket expert, learn from the best: http://wicketinaction.com


--
Become a Wicket expert, learn from the best: http://wicketinaction.com

-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com_______________________________________________
jakartabatch-dev mailing list
jakartabatch-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartabatch-dev