| Re: [jakartabatch-dev] whitespace / formatting |
At $$$ company we have automatic enforcement of formatting by importing the company settings into Eclipse through a resource bundle. I think the scout project copied our approach and made a maven plugin just for this.For a project that is open source, forcing eclipse might be a bridge too far (even though we're at the Eclipse Foundation).That said, picking a standard that is implemented across the different IDE's and enforcing that through- default settings that can be imported at the project level- a checkstyle pluginwould be good.While I don't have a love for the sun coding standards, I think those are widely supported across IDEs.MartijnOn Tue, Mar 31, 2020 at 5:00 PM Scott Kurz <skurz@xxxxxxxxxx> wrote:_______________________________________________For each of the API/TCK projects, I don't think we ever paid too much attention to consistent formatting. I'd have to check what our EOL situation is as well.
If anyone wants to be the first to propose a format and possibly enforcement (e.g. checkstyle) be my guest.
Otherwise, I'm going to try to just reject PRs that mix reformatting with content changes.
Though for something like this:
https://github.com/thadumi/batch-tck/commit/c9b29b42d68eeb4c12cc264897079be926493737
I think I'd just break that into two commits: one removing trailing whitespace for all Java parts and then the content.
Tried to note this here: https://github.com/eclipse-ee4j/batch-api/wiki/Ways-To-Contribute
But if you're interested, please feel free to propose/implement.
------------------------------------------------------
Scott Kurz
WebSphere Batch and Developer Experience
skurz@xxxxxxxxxx
--------------------------------------------------------
jakartabatch-dev mailing list
jakartabatch-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartabatch-dev
--Become a Wicket expert, learn from the best: http://wicketinaction.com