Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [iot-pmc] Small patch exceptions?
This is fully clear.
But my question was not about the general case, but the specific one (a simple typo): The git log will show the author that does not have an ECA as the commit author, while the commit message will have my name as a sign-off. Just wanted to make sure that this is ok and that your IP log tooling does not expect the git commit author to mandatorily have an ECA.

Kai

On 30. Aug 2018, at 17:48, Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx> wrote:

If you use squash an merge for multiple commits, you really should use the Also-by feature to list the authors of squashed commits. In the general case, those authors must have ECAs.

Wayne

On Thu, Aug 30, 2018 at 11:44 AM, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:
 I hope that this makes sense.

Absolutely.

I'm expecting that this statement may inspire an additional "lasterer" or "most lastest question" :-)

Feel free to answer any further question that comes to your mind and that nobody has asked yet - my only open one is the „last" one. As a reminder, here it is again:

Can I use the Github „squash&merge“ feature in that case? It allows me to add my sign-off and mentioning the author through „Also-by“. BUT in the git log, the commit will still show the other name as „Author“. Is this fine or must the sign-off name correspond to the technical commit author?

Cheers,
Kai


On 30. Aug 2018, at 15:41, Wayne Beaton <wayne.beaton@eclipse-foundation.org> wrote:

Because we may be setting a precedent that others may observe, I want to make certain here that we don't start treating this "Also-by" feature to work around the process and the checks-and-balances we have in place to enforce them. In this case, we're concerned about some minor spelling fixes that have been described to you, you've fixed, and would like to give a little credit to the individual who noticed the problem. This feature cannot be used to accept meaningful contributions from people who can't or just don't want to sign the ECA. There is a significant difference between "hey, you misspelled a word" and "here's a line of code". You can use the "Also-by" in the latter case, but the individual would have to have an ECA. I hope that this makes sense.

I'm expecting that this statement may inspire an additional "lasterer" or "most lastest question" :-)

Are Github noreply email addresses ok for „Also-by“ authors or do they have to provide a proper email address?

A GitHub noreply email address uniquely identifies an individual. So, sure. That okay. If they ever end up creating an Eclipse Foundation account, we can associate that email with the account.

Wayne


On Thu, Aug 30, 2018 at 4:22 AM, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:
And another „laster“ question: 

Are Github noreply email addresses ok for „Also-by“ authors or do they have to provide a proper email address?

Thanks,
Kai


On 29. Aug 2018, at 15:47, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:

That’s great news! I actually wasn’t aware of that and always asked any co-author to also sign the ECA. Makes my life simpler from now on :-)

Just one last question, if you allow:

Can I use the Github „squash&merge“ feature in that case? It allows me to add my sign-off and mentioning the author through „Also-by“. BUT in the git log, the commit will still show the other name as „Author“. Is this fine or must the sign-off name correspond to the technical commit author?

Regards,
Kai


On 29. Aug 2018, at 15:10, Wayne Beaton <wayne.beaton@eclipse-foundation.org> wrote:

So what you are saying is that authors that are mentioned as an „Also-by“ do NOT necessarily require an ECA? Only the person creating the commit needs to have the ECA?

Correct. We do not require that "Also-by" authors have an ECA.

Wayne 

On Wed, Aug 29, 2018 at 8:49 AM, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:
Thanks Wayne, I have just resent my mail in case it went to any spam folder…

So what you are saying is that authors that are mentioned as an „Also-by“ do NOT necessarily require an ECA? Only the person creating the commit needs to have the ECA?

Cheers,
Kai


On 29. Aug 2018, at 14:01, Wayne Beaton <wayne.beaton@eclipse-foundation.org> wrote:

My apologies. I don't see anything in the EMO inbox.

You can give credit by adding an "Also-by" footer in the Git commit message. The listed individual will appear in the IP Log and in the charts on the project pages.


Wayne

On Wed, Aug 29, 2018 at 7:52 AM, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:
Thanks, Mike.

> I would suggest asking for assistance from emo@xxxxxxxxxxxxxxxxxxxxxx.

I already reached out to EMO last week and will keep waiting for a response and post here, if there is any outcome.

Cheers,
Kai


> On 29. Aug 2018, at 13:50, Mike Milinkovich <mike.milinkovich@eclipse-foundation.org> wrote:
>
> On 2018-08-27 5:06 AM, Kai Kreuzer wrote:
>> Dear PMC colleagues,
>>
>> This is probably a noob question, but I think to remember that in the past there was something like a „small patch exception“, which allowed to accept typo fixes and single line comment/documentation changes to be accepted without requiring an ECA from the contributor.
>>
>> I am not sure whether I only dreamt of that exception, because I cannot find anything about it in the committer handbook nor anywhere on the web…
>>
>> I’m just asking as I am not sure how to correctly handle https://github.com/eclipse/smarthome/pull/6117 - asking the person to add a sign-off, register an Eclipse account and sign the ECA just to change an „an“ to an „and“ is imho the safest way to scare him off and never ever see him again…
>>
>> So do we have any exceptional rules that I am not aware of and that can be applied here? How do you handle such situations?
>
> I would suggest asking for assistance from emo@xxxxxxxxxxxxxxxxxxxxxx.
>
> If there isn't currently a way to do this, please open a bug and we will look into it. I agree that there should be a lightweight mechanism to accept one letter corrections.
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
> _______________________________________________
> iot-pmc mailing list
> iot-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/iot-pmc

_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc



--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation
_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc


_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc




--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation
_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc



_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc




--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation
_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc


_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc




--
Wayne Beaton
Director of Open Source Projects
The Eclipse Foundation
_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc

Back to the top